Brian Tiger Chow
a95dfdcf82
fix(2/pin) optionvalue signature
2014-11-14 03:19:58 -08:00
Brian Tiger Chow
b6f89db1d4
fix(mount_unix) optionvalue signature
...
@mappum can you just sanity check me here with a quick LGTM CR?
2014-11-14 03:19:58 -08:00
Brian Tiger Chow
654fa3fe96
fix(commands/mount_unix, optionvalue) handle found, !found
...
@mappum, could you provide a quick LGTM?
2014-11-14 03:19:57 -08:00
Brian Tiger Chow
c46102cec5
fix(commands/http/handler) check if found
...
@mappum, could you CR this and let me know if I've interpreted the
desired behavior correctly?
2014-11-14 03:19:57 -08:00
Brian Tiger Chow
bff646fb26
fix(commands/optionvalue) don't shadow the return variable
...
NB: return variables are provided for clarity. Otherwise, it's not
entirely clear that the bool is for _found_.
2014-11-14 03:19:57 -08:00
Brian Tiger Chow
3c4f628493
tests(commands/option) test the OptionValue methods
...
TODO add tests for remaning, untested methods.
2014-11-14 03:19:57 -08:00
Brian Tiger Chow
69374b30be
refactor(commands/optionvalue) use
...
@mappum this optionvalue is a really great abstraction. It makes
maintenance super simple!
@jbenet @whyrusleeping
2014-11-14 03:19:57 -08:00
Brian Tiger Chow
71e92dace2
explain(commands/http)
...
we've gotta allow the code to speak for itself. I wouldn't have been
able to safely modify this code without having my hand held. I am but a
lowly programmer with a simple mind.
cc @jbenet @whyrusleeping @mappum
2014-11-14 03:19:57 -08:00
Brian Tiger Chow
9f801561fd
feat(commands) add cast error
2014-11-14 03:19:57 -08:00
Matt Bell
a4e68c241b
commands/http: Get string representations of option values when creating querystring
2014-11-14 03:19:57 -08:00
Juan Batiz-Benet
49792b2362
refactored cast errors to use a util
2014-11-14 03:19:56 -08:00
Juan Batiz-Benet
f6c1cefe60
cmds/add fixed add output
2014-11-14 03:17:43 -08:00
Juan Batiz-Benet
0e41e19305
add logging file
2014-11-14 03:17:43 -08:00
Matt Bell
81dbb23602
commands: Cleanup Requests after command execution returns
2014-11-14 03:17:43 -08:00
Matt Bell
8c9ee52a93
commands: Fixed value mutation bug in Request#SetOption
2014-11-14 03:17:42 -08:00
Juan Batiz-Benet
6faeee8300
cmds2/add: temp fix for -r. horrible hack
...
This will be removed soon, just gets us past landing cmds2.
2014-11-14 03:17:42 -08:00
Juan Batiz-Benet
e32ed36ee9
cmds2/add: return correct error
2014-11-14 03:17:42 -08:00
Brian Tiger Chow
94e8218be8
add todo
2014-11-14 03:17:42 -08:00
Brian Tiger Chow
fcabf22266
feat(ipfs2/config) impl show and edit as options
...
verified that option text hints match ipfs1 - btc
2014-11-14 03:17:42 -08:00
Brian Tiger Chow
45526224e4
todo
...
@mappum, it's okay to make it a read TODO. in fact, it's a really nice
practice since it's standard and we can grep it. When someone who
has an answer for the concern comes across the standard TODO breadcrumb,
he/she can address it. Using the conventional TODO improves
discoverability.
2014-11-14 03:17:42 -08:00
Matt Bell
7a505b44c7
Handle -h and --help differently (short text vs long text)
2014-11-14 03:17:42 -08:00
Matt Bell
c76a52e422
cmd/ipfs2: Show short help text instead for usage errors
2014-11-14 03:17:42 -08:00
Matt Bell
93c69a83e8
commands/cli: Added short help text function
2014-11-14 03:17:41 -08:00
Matt Bell
4970d8b5a3
commands/cli: Use template for helptext generation
2014-11-14 03:17:41 -08:00
Brian Tiger Chow
ea15bd6ffe
docs(commands) amend
2014-11-14 03:17:41 -08:00
Brian Tiger Chow
e6f2de40dc
docs(commands) Type
2014-11-14 03:17:41 -08:00
Brian Tiger Chow
f5973b5565
add urgent todo. fix before merge
2014-11-14 03:17:41 -08:00
Brian Tiger Chow
981f18bb49
change(Makefile) make install -> make install_1, make install_2
2014-11-14 03:17:41 -08:00
Matt Bell
e23b537f32
Override root command help text
2014-11-14 03:17:41 -08:00
Matt Bell
7666f8880c
commands: Allow overriding helptext sections with hand-written strings
2014-11-14 03:17:41 -08:00
Matt Bell
6869ca44fa
core/command2: Fixed indentation
2014-11-14 03:17:41 -08:00
Matt Bell
f93b806d21
commands/http: s/lenRequired/numRequired/
2014-11-14 03:17:40 -08:00
Matt Bell
50751617b6
commands: s/j/valueIndex/
2014-11-14 03:17:40 -08:00
Matt Bell
eedc2e9cc7
commands: s/lenRequired/numRequired/
2014-11-14 03:17:40 -08:00
Matt Bell
e14471f5e8
commands/cli: Use better variable name for parseArgs value index
2014-11-14 03:17:40 -08:00
Matt Bell
5481230679
commands/cli: Use better temp variable names in Parse
2014-11-14 03:17:40 -08:00
Matt Bell
f48ce10efb
commands/cli: Added comment to explain multiple root support in Parse
2014-11-14 03:17:40 -08:00
Matt Bell
b358bb3ffd
cmd/ipfs2: Added comment to explain default encoding logic
2014-11-14 03:17:40 -08:00
Matt Bell
aea2fce987
cmd/ipfs2: Added explanation comment to ipfsHandler
2014-11-14 03:17:40 -08:00
Matt Bell
4902361fd5
cmd/ipfs2: Updated readme
2014-11-14 03:17:40 -08:00
Matt Bell
c468a4dbf5
core/commands2: Use Argument constructors in commands
2014-11-14 03:17:39 -08:00
Matt Bell
40e96a1fa6
commands: Added Argument helper constructors
2014-11-14 03:17:39 -08:00
Brian Tiger Chow
8b14012bba
refactor(ipfs2/main) rm exit
2014-11-14 03:17:39 -08:00
Brian Tiger Chow
ad5ad912ce
refactor(ipfs2/main) use guard
2014-11-14 03:17:39 -08:00
Brian Tiger Chow
74b38cb65f
refactor(ipfs2/main) change the way we handle profiling
2014-11-14 03:17:39 -08:00
Brian Tiger Chow
d72af9c910
refactor(ipfs2/main) return err
2014-11-14 03:17:39 -08:00
Brian Tiger Chow
9268bdd56e
refactor(ipfs2/main) replace with equivalent action
2014-11-14 03:17:39 -08:00
Brian Tiger Chow
fa5ca3f27f
refactor(ipfs2/main) output response
2014-11-14 03:17:39 -08:00
Brian Tiger Chow
cda68a19d0
refactor(ipfs2/main) return err
2014-11-14 03:17:39 -08:00
Brian Tiger Chow
13a90537d6
refactor(ipfs2/main)
...
* bring debug checking back to top level so we have more control over
CPU profiling.
* bring help text up to top level so we can exit from the program
at the top level instead of within an arbitrary function
2014-11-14 03:17:38 -08:00
