coosld/kubo
1
0
Fork 0
mirror of https://github.com/ipfs/kubo.git synced 2026-02-27 13:27:50 +08:00
Code Issues Actions 13 Packages Projects Releases Wiki Activity
2,351 Commits 160 Branches 213 Tags 122 MiB
9328fbaf81
Commit Graph

2351 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jeromy
9328fbaf81 clean peerset constructor names 2014-12-17 23:44:46 -08:00
Brian Tiger Chow
8100582e38 fix: batches of blocks have equal priority 
addresses...

https://github.com/jbenet/go-ipfs/pull/438/files#r21878994

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:46 -08:00
Brian Tiger Chow
bd3ee739b9 doc: some comments about the future of the decision engine 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:46 -08:00
Brian Tiger Chow
ce2d0a2258 fix: add lock to taskQueue 
@whyrusleeping may wanna have a look and make sure i didn't screw
anything up here

BenchmarkInstantaneousAddCat1MB-4            200          10763761 ns/op
97.42 MB/s
BenchmarkInstantaneousAddCat2MB-4       panic: runtime error: invalid
memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0xbedd]

goroutine 14297 [running]:
github.com/jbenet/go-ipfs/exchange/bitswap/decision.(*taskQueue).Remove(0xc2087553a0,
        0xc2085ef200, 0x22, 0x56f570, 0xc208367a40)
    /Users/btc/go/src/github.com/jbenet/go-ipfs/exchange/bitswap/decision/taskqueue.go:66
    +0x82
github.com/jbenet/go-ipfs/exchange/bitswap/decision.(*Engine).MessageSent(0xc20871b5c0,
        0x56f570, 0xc208367a40, 0x570040, 0xc208753d40, 0x0, 0x0)
    /Users/btc/go/src/github.com/jbenet/go-ipfs/exchange/bitswap/decision/engine.go:177
    +0x29e
github.com/jbenet/go-ipfs/exchange/bitswap.(*bitswap).send(0xc20871b7a0,
        0x56f4d8, 0xc208379800, 0x56f570, 0xc208367a40,
        0x570040, 0xc208753d40, 0x0, 0x0)
    /Users/btc/go/src/github.com/jbenet/go-ipfs/exchange/bitswap/bitswap.go:352
    +0x11c
github.com/jbenet/go-ipfs/exchange/bitswap.(*bitswap).taskWorker(0xc20871b7a0,
        0x56f4d8, 0xc208379800)
    /Users/btc/go/src/github.com/jbenet/go-ipfs/exchange/bitswap/bitswap.go:238
    +0x165
    created by
    github.com/jbenet/go-ipfs/exchange/bitswap.New
    /Users/btc/go/src/github.com/jbenet/go-ipfs/exchange/bitswap/bitswap.go:66
    +0x49e
 2014-12-17 23:44:46 -08:00
Brian Tiger Chow
175513e281 refactor(bs/decision.Engine): pass in Entry 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:46 -08:00
Brian Tiger Chow
4bcfe094a1 extract constants 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:46 -08:00
Brian Tiger Chow
0545c4d15d refactor: *Entry -> Entry 
in many places, entries are assigned from one slice to another and in
different goroutines. In one place, entries were modified (in the
queue). To avoid shared mutable state, probably best to handle entries
by value.

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:46 -08:00
Brian Tiger Chow
19764880d8 doc: peerset fixme 
not changing this because i don't want to write a test for it now

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:46 -08:00
Brian Tiger Chow
45faa4d7a0 fix: set peerset size 
addresses https://github.com/jbenet/go-ipfs/pull/438#discussion_r21952271

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:45 -08:00
Brian Tiger Chow
e36d656632 log unusual event 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:45 -08:00
Brian Tiger Chow
2b60b641c4 fix: check blockstore before adding task 
addresses https://github.com/jbenet/go-ipfs/pull/438#discussion_r21953742

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:45 -08:00
Brian Tiger Chow
6e7c46a6e2 unexport functions 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:45 -08:00
Brian Tiger Chow
9c301a2d77 add comment 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:45 -08:00
Brian Tiger Chow
1b1260b658 rm unused method 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:45 -08:00
Brian Tiger Chow
8d4d5b86ef fix: don't sort the output of Entries() 
only sort SortedEntries()

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:45 -08:00
Brian Tiger Chow
acc714823b rename to peerRequestQueue 
this opens up the possibility of having multiple queues. And for all
outgoing messages to be managed by the decision engine

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:45 -08:00
Brian Tiger Chow
1d23e94f16 rm empty file 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:45 -08:00
Brian Tiger Chow
5bd0b95462 rename to strategy.LedgerManager to decision.Engine 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:44 -08:00
Brian Tiger Chow
bef622222d refactor: wantlist splits into WL and ThreadSafe WL 
bitswap keeps the threadsafe version. observing the ledger shows that it
doesn't need it anymore (ledgermanager is protected and safe).

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:44 -08:00
Brian Tiger Chow
d069ae11f4 refactor: put mutex next to the things it protects 
If we put the lock next to the fields it protects, it can sometimes make
it easier to reason about threadsafety.

In this case, it reveals that the task queue (not threadsafe) isn't protected by the
mutex, yet shared between the worker and callers.

@whyrusleeping

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:44 -08:00
Brian Tiger Chow
962a9477cc refactor: remove ledgerMap type 
it's only used in two places, but i think we've been using maps on IPFS
types so much now that the specificity is no longer necessary

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:44 -08:00
Brian Tiger Chow
39d71931a8 mv comment 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:44 -08:00
Brian Tiger Chow
7fdbae1306 refactor: separate responsibilties 
Before, priority carried two pieces of information.

One: priority as defined by remote peer
Two: whether task is trashed

This assumes the protocol is defined for natural numbers instead of
integers. That may not always be the case. Better to leave that
assumption outside so this package isn't coupled to the whims of the
protocol.

The protocol may be changed to allow any integer value to be used.
Hopefully by that time, new responsibilties weren't added to the
Priority variable.

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:44 -08:00
Brian Tiger Chow
fedcebf67a refactor: re-use wantlist.Entry type wherever it makes sense 
it seems to make sense since, in each place, the Key and Priority
represent the same information

b/c you know the saying...

"It is better to have 100 functions operate on one data structure than
10 functions on 10 data structures."

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:44 -08:00
Brian Tiger Chow
1d715956f5 doc: add comment to Envelope 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:44 -08:00
Brian Tiger Chow
e11f099c42 privatize Task 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:44 -08:00
Brian Tiger Chow
181ff4eab1 tq.Cancel -> tq.Remove 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:43 -08:00
Brian Tiger Chow
198aa1959a it's not a queue yet but it's okay to name it as such 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:43 -08:00
Brian Tiger Chow
7280aac83f perf: avoid lots of communication by signaling once at end of method 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:43 -08:00
Brian Tiger Chow
cc2a7312a2 add comment to fix race 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:43 -08:00
Brian Tiger Chow
b41fef2fff refactor: remove peerKey type 
we've been using maps with peers long enough now that this probably is
no longer necessary

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:43 -08:00
Brian Tiger Chow
286723d888 unexport task and taskList 
the less bitswap has to know about, the easier it'll be for readers.
(This now returns Messages.)

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:43 -08:00
Brian Tiger Chow
93fde86d18 refactor: taskKey := p.Key() + block.Key() 
for clarity and to avoid errors, define a function

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:43 -08:00
Brian Tiger Chow
460967839e doc: comment 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:43 -08:00
Brian Tiger Chow
10e970c0cf refactor: context first in argument list 
(merely by convention)

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:43 -08:00
Brian Tiger Chow
f66d94aaf1 fix: move the check into the function. 
function should be a no-op when passed an empty slice

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:42 -08:00
Brian Tiger Chow
8c05c444a5 refactor: avoid loop reuse 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:42 -08:00
Brian Tiger Chow
2ea8ed81ac refactor: change Tasks to Outbox 
notice that moving the blockstore fetch into the manager removes the
weird error handling case.

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:42 -08:00
Brian Tiger Chow
a495a014af style constify variables 
good to const until it's required for them to be variable.

TODO pass them in as configuration options
 2014-12-17 23:44:42 -08:00
Brian Tiger Chow
8bef1dce80 fix: move to callsite so public callers don't experience the internal timeout rule 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:42 -08:00
Brian Tiger Chow
5603b2e0a4 style: line wrapping 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:42 -08:00
Brian Tiger Chow
c0a18d9c08 fix(test): nil Blockstore 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:42 -08:00
Jeromy
69dd260236 refactor peerSet 2014-12-17 23:44:42 -08:00
Brian Tiger Chow
f533678724 avoid attaching context to object when it's not necessary. 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:42 -08:00
Brian Tiger Chow
f028c44fd2 name findOrCreate 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:41 -08:00
Brian Tiger Chow
1bced710b1 queue-like naming 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:41 -08:00
Brian Tiger Chow
29ef238fa3 remove dead code 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:41 -08:00
Brian Tiger Chow
86c438b6e1 refactor() message API 
performing CR in the form of a PR. Let me know what you think.

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-17 23:44:41 -08:00
Jeromy
6389bfda6b some cleanup before CR 2014-12-17 23:44:41 -08:00
Jeromy
2240272d85 change Provide RPC to not wait for an ACK, improves performance of 'Add' operations 2014-12-17 23:44:41 -08:00