Commit Graph

1605 Commits

Author SHA1 Message Date
Matt Bell
3e7592f2cc commands/cli: Sort options by length when generating options helptext 2014-11-14 03:20:02 -08:00
Matt Bell
e41f861f8a commands/cli: Added some TODOs to Parse 2014-11-14 03:20:02 -08:00
Matt Bell
092524fcbb cmd/ipfs2: Added a 'commands' command for CLI root 2014-11-14 03:20:01 -08:00
Matt Bell
f797d13579 core/commands2: Added function to generate a 'commands' command for a root 2014-11-14 03:20:01 -08:00
Matt Bell
fd8b1930af cmd/ipfs2: Copy subcommands from core/commands2 root into cmd/ipfs2 root 2014-11-14 03:20:01 -08:00
Matt Bell
53e875e5fc core/commands2: Format 'commands' to match original output (re: #317) 2014-11-14 03:20:01 -08:00
Brian Tiger Chow
4e740f63eb docs(ipfs2/main)
@mappum

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
2014-11-14 03:20:01 -08:00
Brian Tiger Chow
22a4cc7d30 fix(ipfs2) output info to logger when checking daemon status 2014-11-14 03:20:01 -08:00
Juan Batiz-Benet
86b08f4e4b cmds2 config outputs nicely 2014-11-14 03:20:01 -08:00
Juan Batiz-Benet
a2d06b5f9a cmds2: errHelpRequested error 2014-11-14 03:20:01 -08:00
Juan Batiz-Benet
f2c54f5a4b cmd2 bootstrapCmd missing type 2014-11-14 03:20:00 -08:00
Juan Batiz-Benet
b836e72aea cmd2 align arguments properly 2014-11-14 03:20:00 -08:00
Juan Batiz-Benet
c0b3b43773 cmds2/helptext moved indent + tagline in subcmd 2014-11-14 03:20:00 -08:00
Matt Bell
80d743541e commands/cli: Fixed spacing error 2014-11-14 03:20:00 -08:00
Juan Batiz-Benet
ef4480fe6d cmds/config: better help text 2014-11-14 03:20:00 -08:00
Juan Batiz-Benet
fc7c199d6a cmds/helptext: indent + newlines + synopsis 2014-11-14 03:20:00 -08:00
Brian Tiger Chow
3c9fb48699 fix(2/bootstrap) catch hidden panic
@mappum any idea what might cause the type to not match here?
2014-11-14 03:20:00 -08:00
Matt Bell
8aa532fbc9 commands/cli: Less line breaks in autogenerated formatting 2014-11-14 03:20:00 -08:00
Matt Bell
78bc748342 cmd/ipfs: Fixed bug where handleParseError sets error to nil 2014-11-14 03:19:59 -08:00
Juan Batiz-Benet
ec8be23cbc cmds/main decomposed handleParseError 2014-11-14 03:19:59 -08:00
Juan Batiz-Benet
c25bf522d6 newline in short helptext 2014-11-14 03:19:59 -08:00
Matt Bell
47987f5df5 commands/cli: Transitionary commit - Generate helptext from HelpText fields if they aren't empty 2014-11-14 03:19:59 -08:00
Matt Bell
475f3f485b commands: Added HelpText struct to organize different help text fields in Commands 2014-11-14 03:19:59 -08:00
Brian Tiger Chow
7116591351 docs(commands/request) 2014-11-14 03:19:59 -08:00
Brian Tiger Chow
192377a852 fix(commands/optionvalue) use the util.ErrCast() 2014-11-14 03:19:59 -08:00
Brian Tiger Chow
cc37cc18c9 question(mount_unix) add todo regarding mount timeout
@whyrusleeping @jbenet

is this non-deterministic?
2014-11-14 03:19:59 -08:00
Brian Tiger Chow
7060e7dfe2 rename variable 2014-11-14 03:19:58 -08:00
Brian Tiger Chow
33ba3f6321 refactor(mount_unix) return the errs in select
fix(mount_unix) rm extraneous error
2014-11-14 03:19:58 -08:00
Brian Tiger Chow
fed2f8d2c6 fix(2/main) option value signature 2014-11-14 03:19:58 -08:00
Brian Tiger Chow
013d98a35a fix(2/init, 2/add) fix optionvalue signature 2014-11-14 03:19:58 -08:00
Brian Tiger Chow
3493e33ec9 fix(2/version) option value sig 2014-11-14 03:19:58 -08:00
Brian Tiger Chow
7c75227190 fix(2/refs) optionvalue signature
@mappum this one is straightforward, but tagging you here just in case
2014-11-14 03:19:58 -08:00
Brian Tiger Chow
a95dfdcf82 fix(2/pin) optionvalue signature 2014-11-14 03:19:58 -08:00
Brian Tiger Chow
b6f89db1d4 fix(mount_unix) optionvalue signature
@mappum can you just sanity check me here with a quick LGTM CR?
2014-11-14 03:19:58 -08:00
Brian Tiger Chow
654fa3fe96 fix(commands/mount_unix, optionvalue) handle found, !found
@mappum, could you provide a quick LGTM?
2014-11-14 03:19:57 -08:00
Brian Tiger Chow
c46102cec5 fix(commands/http/handler) check if found
@mappum, could you CR this and let me know if I've interpreted the
desired behavior correctly?
2014-11-14 03:19:57 -08:00
Brian Tiger Chow
bff646fb26 fix(commands/optionvalue) don't shadow the return variable
NB: return variables are provided for clarity. Otherwise, it's not
entirely clear that the bool is for _found_.
2014-11-14 03:19:57 -08:00
Brian Tiger Chow
3c4f628493 tests(commands/option) test the OptionValue methods
TODO add tests for remaning, untested methods.
2014-11-14 03:19:57 -08:00
Brian Tiger Chow
69374b30be refactor(commands/optionvalue) use
@mappum this optionvalue is a really great abstraction. It makes
maintenance super simple!

@jbenet @whyrusleeping
2014-11-14 03:19:57 -08:00
Brian Tiger Chow
71e92dace2 explain(commands/http)
we've gotta allow the code to speak for itself. I wouldn't have been
able to safely modify this code without having my hand held. I am but a
lowly programmer with a simple mind.

cc @jbenet @whyrusleeping @mappum
2014-11-14 03:19:57 -08:00
Brian Tiger Chow
9f801561fd feat(commands) add cast error 2014-11-14 03:19:57 -08:00
Matt Bell
a4e68c241b commands/http: Get string representations of option values when creating querystring 2014-11-14 03:19:57 -08:00
Juan Batiz-Benet
49792b2362 refactored cast errors to use a util 2014-11-14 03:19:56 -08:00
Juan Batiz-Benet
f6c1cefe60 cmds/add fixed add output 2014-11-14 03:17:43 -08:00
Juan Batiz-Benet
0e41e19305 add logging file 2014-11-14 03:17:43 -08:00
Matt Bell
81dbb23602 commands: Cleanup Requests after command execution returns 2014-11-14 03:17:43 -08:00
Matt Bell
8c9ee52a93 commands: Fixed value mutation bug in Request#SetOption 2014-11-14 03:17:42 -08:00
Juan Batiz-Benet
6faeee8300 cmds2/add: temp fix for -r. horrible hack
This will be removed soon, just gets us past landing cmds2.
2014-11-14 03:17:42 -08:00
Juan Batiz-Benet
e32ed36ee9 cmds2/add: return correct error 2014-11-14 03:17:42 -08:00
Brian Tiger Chow
94e8218be8 add todo 2014-11-14 03:17:42 -08:00