mirror of
https://github.com/ipfs/kubo.git
synced 2026-02-22 10:57:42 +08:00
5ce2deb5fc
In TestExternalUnmount, the Mount function is called which returns an
error which can be nil. The error type is then used in a comparison
where Error() is called on it. If the error is nil, this results in a
panic.
Added a if err != nil {} guard to make sure that Error() is not called
if the value is nil
On branch go-test-fix
Changes to be committed:
modified: fuse/node/mount_test.go
License: MIT
Signed-off-by: Chris Buesser <christopher.buesser@gmail.com>
96 lines
1.8 KiB
Go
96 lines
1.8 KiB
Go
// +build !nofuse
|
|
|
|
package node
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"bazil.org/fuse"
|
|
|
|
"context"
|
|
|
|
core "github.com/ipfs/go-ipfs/core"
|
|
ipns "github.com/ipfs/go-ipfs/fuse/ipns"
|
|
mount "github.com/ipfs/go-ipfs/fuse/mount"
|
|
|
|
ci "github.com/libp2p/go-testutil/ci"
|
|
)
|
|
|
|
func maybeSkipFuseTests(t *testing.T) {
|
|
if ci.NoFuse() {
|
|
t.Skip("Skipping FUSE tests")
|
|
}
|
|
}
|
|
|
|
func mkdir(t *testing.T, path string) {
|
|
err := os.Mkdir(path, os.ModeDir|os.ModePerm)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
// Test externally unmounting, then trying to unmount in code
|
|
func TestExternalUnmount(t *testing.T) {
|
|
if testing.Short() {
|
|
t.SkipNow()
|
|
}
|
|
|
|
// TODO: needed?
|
|
maybeSkipFuseTests(t)
|
|
|
|
node, err := core.NewNode(context.Background(), &core.BuildCfg{})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
err = ipns.InitializeKeyspace(node, node.PrivateKey)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// get the test dir paths (/tmp/fusetestXXXX)
|
|
dir, err := ioutil.TempDir("", "fusetest")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
ipfsDir := dir + "/ipfs"
|
|
ipnsDir := dir + "/ipns"
|
|
mkdir(t, ipfsDir)
|
|
mkdir(t, ipnsDir)
|
|
|
|
err = Mount(node, ipfsDir, ipnsDir)
|
|
if err != nil {
|
|
if strings.Contains(err.Error(), "unable to check fuse version") || err == fuse.ErrOSXFUSENotFound {
|
|
t.Skip(err)
|
|
}
|
|
}
|
|
|
|
if err != nil {
|
|
t.Fatalf("error mounting: %v", err)
|
|
}
|
|
|
|
// Run shell command to externally unmount the directory
|
|
cmd, err := mount.UnmountCmd(ipfsDir)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if err := cmd.Run(); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// TODO(noffle): it takes a moment for the goroutine that's running fs.Serve to be notified and do its cleanup.
|
|
time.Sleep(time.Millisecond * 100)
|
|
|
|
// Attempt to unmount IPFS; it should unmount successfully.
|
|
err = node.Mounts.Ipfs.Unmount()
|
|
if err != mount.ErrNotMounted {
|
|
t.Fatal("Unmount should have failed")
|
|
}
|
|
}
|