mirror of
https://github.com/ipfs/kubo.git
synced 2026-03-10 18:57:57 +08:00
address code review feedback for PR #11069: - fix: propagate decode errors in client/rpc dag import (was silently dropping errors) - fix: acquire pinlock before spawning goroutine to prevent race with GC - fix: update fast-provide test to always expect failure in isolated environment - test: add proper json compatibility test for provide stats (replaces compile-time check) - docs: add educational comments explaining batch config defaults - style: standardize error messages to use consistent "failed to X: %w" pattern the pinlock fix is critical - moving acquisition before goroutine spawn prevents blocks from being garbage collected before the lock is held. the error handling fix ensures RPC clients receive decode errors instead of empty results. |
||
|---|---|---|
| .. | ||
| test | ||
| block.go | ||
| coreapi.go | ||
| dag.go | ||
| key.go | ||
| name.go | ||
| object.go | ||
| path.go | ||
| pin.go | ||
| pubsub.go | ||
| routing.go | ||
| swarm.go | ||
| unixfs.go | ||