This adds a plugin interface that lets the plugin modify the fx options that are passed to fx when the app is initialized. This means plugins can inject their own implementations of IPFS interfaces. This enables granular customization of go-ipfs behavior by plugins, such as: - Bitswap with custom filters (e.g. for CID blocking) Custom interface - implementations such as Pinner or DAGService - Dynamic configuration of libp2p ... One downside of this is that we're exposing the entire dependency graph, init hooks, initialization, etc. to users, so this comes with a caveat that we reserve the right to make breaking changes to the graph structure and initialization logic (although this historically happens rarely). If these things are changed, we should mention them in release notes and changelogs though, since they could impact users of this plugin interface. I'm not particularly fond of DI frameworks (and neither are some of the folks work on/near go-ipfs), but it seems unlikely that somebody will rewrite the dependency wiring and lifecycle hooks of go-ipfs, and add dynamic extension points, so this seems like a palatable compromise. There are also problems that we should clean up in how model the go-ipfs app in fx, such as: - We make extensive use of nested fx.Options, which fx itself discourages because it "limits the user's ability to customize their application". It should be easy to flatten these out into a single []fx.Option slice. - We pass around a list of opaque libp2p opts, which makes it hard to customize after-the-fact...we should consider naming each of these opts and providing them to fx as proper dependencies, so that they can be explicitly overridden. - We call fx.Invoke() in some places with anonymous functions. We should instead only pass exported functions to fx.Invoke(), so that they have exported names, which would make it easier to remove/augment the invocations that happen when the app is initialized. These aren't blocking issues, they just make it harder and more brittle to customize go-ipfs with this plugin. |
||
|---|---|---|
| .. | ||
| lib | ||
| t0024-files | ||
| t0051-object-data | ||
| t0053-dag-data | ||
| t0054-dag-car-import-export-data | ||
| t0060-data | ||
| t0110-gateway-data | ||
| t0116-prometheus-data | ||
| t0118-gateway-car | ||
| t0165-keystore-data | ||
| t0275-cid-security-data | ||
| t0280-plugin-dag-jose-data | ||
| t0280-plugin-data | ||
| t0280-plugin-git-data | ||
| t0701-delegated-routing-reframe | ||
| .gitignore | ||
| GNUmakefile | ||
| README.md | ||
| Rules.mk | ||
| t0001-tests-work.sh | ||
| t0010-basic-commands.sh | ||
| t0011-completion.sh | ||
| t0015-basic-sh-functions.sh | ||
| t0018-indent.sh | ||
| t0020-init.sh | ||
| t0021-config.sh | ||
| t0022-init-default.sh | ||
| t0023-shutdown.sh | ||
| t0024-datastore-config.sh | ||
| t0025-datastores.sh | ||
| t0026-id.sh | ||
| t0027-rotate.sh | ||
| t0030-mount.sh | ||
| t0031-mount-publish.sh | ||
| t0032-mount-sharded.sh | ||
| t0040-add-and-cat.sh | ||
| t0041-ping.sh | ||
| t0042-add-skip.sh | ||
| t0043-add-w.sh | ||
| t0044-add-symlink.sh | ||
| t0045-ls.sh | ||
| t0046-id-hash.sh | ||
| t0050-block.sh | ||
| t0051-object.sh | ||
| t0052-object-diff.sh | ||
| t0053-dag.sh | ||
| t0054-dag-car-import-export.sh | ||
| t0055-dag-put-json-new-line.sh | ||
| t0060-daemon.sh | ||
| t0061-daemon-opts.sh | ||
| t0062-daemon-api.sh | ||
| t0063-daemon-init.sh | ||
| t0063-external.sh | ||
| t0064-api-file.sh | ||
| t0065-active-requests.sh | ||
| t0066-migration.sh | ||
| t0067-unix-api.sh | ||
| t0070-user-config.sh | ||
| t0080-repo.sh | ||
| t0081-repo-pinning.sh | ||
| t0082-repo-gc-auto.sh | ||
| t0084-repo-read-rehash.sh | ||
| t0085-pins.sh | ||
| t0086-repo-verify.sh | ||
| t0087-repo-robust-gc.sh | ||
| t0088-repo-stat-symlink.sh | ||
| t0090-get.sh | ||
| t0095-refs.sh | ||
| t0100-name.sh | ||
| t0101-iptb-name.sh | ||
| t0110-gateway.sh | ||
| t0111-gateway-writeable.sh | ||
| t0112-gateway-cors.sh | ||
| t0113-gateway-symlink.sh | ||
| t0114-gateway-subdomains.sh | ||
| t0115-gateway-dir-listing.sh | ||
| t0116-gateway-cache.sh | ||
| t0117-gateway-block.sh | ||
| t0118-gateway-car.sh | ||
| t0119-prometheus.sh | ||
| t0120-bootstrap.sh | ||
| t0121-bootstrap-iptb.sh | ||
| t0125-twonode.sh | ||
| t0130-multinode.sh | ||
| t0131-multinode-client-routing.sh | ||
| t0139-swarm-rcmgr.sh | ||
| t0140-swarm.sh | ||
| t0141-addfilter.sh | ||
| t0142-testfilter.sh | ||
| t0150-clisuggest.sh | ||
| t0151-sysdiag.sh | ||
| t0152-profile.sh | ||
| t0160-resolve.sh | ||
| t0165-keystore.sh | ||
| t0170-legacy-dht.sh | ||
| t0170-routing-dht.sh | ||
| t0171-peering.sh | ||
| t0175-provider.sh | ||
| t0175-reprovider.sh | ||
| t0175-strategic-provider.sh | ||
| t0180-p2p.sh | ||
| t0181-private-network.sh | ||
| t0182-circuit-relay.sh | ||
| t0183-namesys-pubsub.sh | ||
| t0184-http-proxy-over-p2p.sh | ||
| t0185-autonat.sh | ||
| t0190-quic-ping.sh | ||
| t0191-noise.sh | ||
| t0200-unixfs-ls.sh | ||
| t0210-tar.sh | ||
| t0220-bitswap.sh | ||
| t0221-graphsync.sh | ||
| t0230-channel-streaming-http-content-type.sh | ||
| t0231-channel-streaming.sh | ||
| t0235-cli-request.sh | ||
| t0236-cli-api-dns-resolve.sh | ||
| t0240-republisher.sh | ||
| t0250-files-api.sh | ||
| t0251-files-flushing.sh | ||
| t0252-files-gc.sh | ||
| t0260-sharding.sh | ||
| t0270-filestore.sh | ||
| t0271-filestore-utils.sh | ||
| t0272-urlstore.sh | ||
| t0275-cid-security.sh | ||
| t0276-cidv0v1.sh | ||
| t0280-plugin-dag-jose.sh | ||
| t0280-plugin-fx.sh | ||
| t0280-plugin-git.sh | ||
| t0280-plugin-peerlog.sh | ||
| t0280-plugin.sh | ||
| t0290-cid.sh | ||
| t0295-multibase.sh | ||
| t0300-docker-image.sh | ||
| t0301-docker-migrate.sh | ||
| t0310-tracing.sh | ||
| t0320-pubsub.sh | ||
| t0321-pubsub-gossipsub.sh | ||
| t0322-pubsub-http-rpc.sh | ||
| t0400-api-no-gateway.sh | ||
| t0401-api-browser-security.sh | ||
| t0410-api-add.sh | ||
| t0500-issues-and-regressions-offline.sh | ||
| t0600-issues-and-regressions-online.sh | ||
| t0700-remotepin.sh | ||
| t0701-delegated-routing-reframe.sh | ||
| t0800-blake3.sh | ||
| x0601-pin-fail-test.sh | ||
ipfs whole tests using the sharness framework
Running all the tests
Just use make in this directory to run all the tests.
Run with TEST_VERBOSE=1 to get helpful verbose output.
TEST_VERBOSE=1 make
The usual ipfs env flags also apply:
# the output will make your eyes bleed
IPFS_LOGGING=debug TEST_VERBOSE=1 make
To make the tests abort as soon as an error occurs, use the TEST_IMMEDIATE env variable:
# this will abort as soon the first error occurs
TEST_IMMEDIATE=1 make
Running just one test
You can run only one test script by launching it like a regular shell script:
$ ./t0010-basic-commands.sh
Debugging one test
You can use the -v option to make it verbose and the -i option to
make it stop as soon as one test fails.
For example:
$ ./t0010-basic-commands.sh -v -i
Sharness
When running sharness tests from main Makefile or when test_sharness_deps
target is run dependencies for sharness
will be downloaded from its github repo and installed in a "lib/sharness"
directory.
Please do not change anything in the "lib/sharness" directory.
If you really need some changes in sharness, please fork it from its canonical repo and send pull requests there.
Writing Tests
Please have a look at existing tests and try to follow their example.
When possible and not too inefficient, that means most of the time,
an ipfs command should not be on the left side of a pipe, because if
the ipfs command fails (exit non zero), the pipe will mask this failure.
For example after false | true, echo $? prints 0 (despite false
failing).
It should be possible to put most of the code inside test_expect_success,
or sometimes test_expect_failure, blocks, and to chain all the commands
inside those blocks with &&, or || for diagnostic commands.
Diagnostics
Make your test case output helpful for when running sharness verbosely. This means cating certain files, or running diagnostic commands. For example:
test_expect_success ".ipfs/ has been created" '
test -d ".ipfs" &&
test -f ".ipfs/config" &&
test -d ".ipfs/datastore" &&
test -d ".ipfs/blocks" ||
test_fsh ls -al .ipfs
'
The || ... is a diagnostic run when the preceding command fails.
test_fsh is a shell function that echoes the args, runs the cmd,
and then also fails, making sure the test case fails. (wouldn't want
the diagnostic accidentally returning true and making it seem like
the test case succeeded!).
Testing commands on daemon or mounted
Use the provided functions in lib/test-lib.sh to run the daemon or mount:
To init, run daemon, and mount in one go:
test_launch_ipfs_daemon_and_mount
test_expect_success "'ipfs add --help' succeeds" '
ipfs add --help >actual
'
# other tests here...
# don't forget to kill the daemon!!
test_kill_ipfs_daemon
To init, run daemon, and then mount separately:
test_init_ipfs
# tests inited but not running here
test_launch_ipfs_daemon
# tests running but not mounted here
test_mount_ipfs
# tests mounted here
# don't forget to kill the daemon!!
test_kill_ipfs_daemon