coosld/kubo
1
0
Fork 0
mirror of https://github.com/ipfs/kubo.git synced 2026-02-26 04:47:45 +08:00
Code Issues Actions 13 Packages Projects Releases Wiki Activity
dag-stat-progress-improvement
kubo/core/commands
History
Hector Sanjuan 7798ad46aa core/commands/dag/stat: improve output 
`ipfs dag stat -h` says:

```
USAGE
  ipfs dag stat <root>... - Gets stats for a DAG.

  ipfs dag stat [--progress=false] [--] <root>...
```

but `--progress` defaults to `true`.

So by default it prints this :

```
ipfs dag stat -progress=true QmUWfSKRTZGTHuYhV4kBTrS8fJEV2GPzeXcdhxUGPuYTnJ
CID: QmUWfSKRTZGTHuYhV4kBTrS8fJEV2GPzeXcdhxUGPuYTnJ, Size: 95, NumBlocks: 1
CID: QmUWfSKRTZGTHuYhV4kBTrS8fJEV2GPzeXcdhxUGPuYTnJ, Size: 202, NumBlocks: 2
CID: QmUWfSKRTZGTHuYhV4kBTrS8fJEV2GPzeXcdhxUGPuYTnJ, Size: 8912, NumBlocks: 3
CID: QmUWfSKRTZGTHuYhV4kBTrS8fJEV2GPzeXcdhxUGPuYTnJ, Size: 271056, NumBlocks: 4
CID: QmUWfSKRTZGTHuYhV4kBTrS8fJEV2GPzeXcdhxUGPuYTnJ, Size: 533200, NumBlocks: 5
...

<actual dag stat summary>.
```

I find this confusing. Is this intended? This PR switches to:

```
ipfs dag stat QmUWfSKRTZGTHuYhV4kBTrS8fJEV2GPzeXcdhxUGPuYTnJ
CID: QmUWfSKRTZGTHuYhV4kBTrS8fJEV2GPzeXcdhxUGPuYTnJ, Size: 95, NumBlocks: -1
CID: QmaCxzMg6FZRkDi61q4ymWcCvoj6GkuBo5mVszi5DHBpb1, Size: 107, NumBlocks: -1
CID: QmUf2ynPG2wCJe3zLaASNJrQKN3BkboD2VRAKcwteDAUQB, Size: 8710, NumBlocks: -1
CID: bafkreibspggfqizukzodgaivbqusjz2xugesiaf3cutlf5rayzkfawhyry, Size: 262144, NumBlocks: -1
CID: bafkreicagz2co2ryds5auotj5kgwbqt7mvfzua4o54fv24rbycodytnmuu, Size: 262144, NumBlocks: -1
...

<actual summary>
```

which means it lists the nodes that are traversed as it makes progress traversing the DAG.
2025-09-24 11:45:42 +02:00
..
cmdenv chore: use go-log/v2 (#10801) 2025-05-19 13:04:05 -07:00
cmdutils fix(cmds): cleanup unicode identify strings (#9465) 2025-09-19 04:46:38 +02:00
dag core/commands/dag/stat: improve output 2025-09-24 11:45:42 +02:00
e Fix typo in an error.go comment: "is adds" -> "adds". 2018-01-17 15:25:54 -08:00
keyencode chore: bump go-libp2p v0.22.0 & go1.18&go1.19 2022-09-09 17:09:38 +02:00
name feat(config): AutoConf with "auto" placeholders (#10883) 2025-08-20 05:59:11 +02:00
object core/commands!: remove deprecated object APIs (#10375) 2024-03-22 09:32:30 +01:00
pin fix: ipfs pin ls <cid> --names (#10970) 2025-09-19 03:17:45 +02:00
active.go refactor: use slices.Sort where appropriate (#10858) 2025-07-08 18:43:23 +02:00
add.go refactor(config): migration 17-to-18 to unify Provider/Reprovider into Provide.DHT (#10951) 2025-09-18 22:17:43 +02:00
bitswap.go fix(rpc): restore and reprecate bitswap reprovide (#10699) 2025-02-10 16:12:53 +01:00
block.go config: introduce Import section (#10421) 2024-05-14 14:17:04 +00:00
bootstrap.go feat(config): AutoConf with "auto" placeholders (#10883) 2025-08-20 05:59:11 +02:00
cat.go chore: use errors.New to replace fmt.Errorf with no parameters (#10617) 2024-12-10 13:50:35 -08:00
cid_test.go Nonfunctional (#10753) 2025-03-11 14:04:16 -07:00
cid.go feat(ci): reusable spellcheck from unified CI (#10873) 2025-08-14 00:35:35 +00:00
commands_test.go feat(config): AutoConf with "auto" placeholders (#10883) 2025-08-20 05:59:11 +02:00
commands.go fix(cmd): exit 1 on error (#10903) 2025-08-08 17:25:05 -07:00
completion.go refactor: use slices.Sort where appropriate (#10858) 2025-07-08 18:43:23 +02:00
config_test.go test: TestEditorParsing 2025-07-08 18:43:47 +02:00
config.go feat(config): AutoConf with "auto" placeholders (#10883) 2025-08-20 05:59:11 +02:00
dht_test.go refactor: namesys cleanup, gateway /ipns/ ttl (#10115) 2023-10-18 10:23:50 +02:00
dht.go chore: use errors.New to replace fmt.Errorf with no parameters (#10617) 2024-12-10 13:50:35 -08:00
diag.go feat: add an "ipfs diag profile" command 2021-07-21 14:51:47 -07:00
external.go style: gofumpt and godot [skip changelog] (#10081) 2023-08-17 14:02:08 +02:00
extra.go refactor: get rid of cmdDetails awkwardness 2020-08-04 18:28:40 -04:00
files_test.go fix(mfs): basic UnixFS sanity checks in files cp (#10701) 2025-03-05 20:40:33 +01:00
files.go fix(mfs): unbound cache growth with flush=false (#10971) 2025-09-19 03:39:55 +02:00
filestore.go Ivan386/filestore fix (#7474) 2025-06-04 14:04:20 -07:00
get_test.go cmdkit -> cmds 2019-05-10 23:00:20 -07:00
get.go feat: Support storing UnixFS 1.5 Mode and ModTime (#10478) 2024-08-21 02:02:46 +02:00
helptext_test.go gx: unrewrite 2019-03-05 18:33:56 +01:00
id.go fix(cmds): cleanup unicode identify strings (#9465) 2025-09-19 04:46:38 +02:00
keystore.go chore: use errors.New to replace fmt.Errorf with no parameters (#10617) 2024-12-10 13:50:35 -08:00
log.go feat: add query functionality to log level command (#10885) 2025-08-11 12:43:48 -07:00
ls.go refactor: use slices.Sort where appropriate (#10858) 2025-07-08 18:43:23 +02:00
mount_nofuse.go refactor(ci): optimize build workflows (#10973) 2025-09-19 14:44:38 +02:00
mount_unix.go refactor(ci): optimize build workflows (#10973) 2025-09-19 14:44:38 +02:00
mount_windows.go cmdkit -> cmds 2019-05-10 23:00:20 -07:00
multibase.go ci: add stylecheck to golangci-lint (#9334) 2022-10-06 10:18:40 -04:00
p2p.go chore: use errors.New to replace fmt.Errorf with no parameters (#10617) 2024-12-10 13:50:35 -08:00
ping.go refactor: stop using go-libp2p deprecated peer.ID.Pretty 2023-09-18 15:58:15 +02:00
profile.go profile: add trace 2024-01-12 14:55:55 +01:00
provide.go refactor(config): migration 17-to-18 to unify Provider/Reprovider into Provide.DHT (#10951) 2025-09-18 22:17:43 +02:00
pubsub.go refactor: use slices.Sort where appropriate (#10858) 2025-07-08 18:43:23 +02:00
refs.go chore: upgrade to go 1.23 (#10486) 2024-08-28 18:56:45 +02:00
repo.go feat(config): AutoConf with "auto" placeholders (#10883) 2025-08-20 05:59:11 +02:00
resolve.go docs(cli): fix spelling 2023-12-04 09:40:21 +01:00
root_test.go core/corehttp!: remove /api/v0 from gateway port 2024-03-05 08:21:13 +00:00
root.go provider: clear provide queue when reprovide strategy changes (#10863) 2025-07-16 01:28:27 -07:00
routing.go fix: allow custom http provide when libp2p node is offline (#10974) 2025-09-19 18:55:42 +02:00
shutdown.go refactor: rename to kubo 2022-07-06 18:40:37 +02:00
stat_dht.go fix(cmds): cleanup unicode identify strings (#9465) 2025-09-19 04:46:38 +02:00
stat_provide.go refactor: move ipfs stat provide/reprovide to ipfs provide stat (#10896) 2025-08-07 17:17:00 -07:00
stat_reprovide.go feat(ci): reusable spellcheck from unified CI (#10873) 2025-08-14 00:35:35 +00:00
stat.go feat: Provider.WorkerCount and stats reprovide (#10779) 2025-04-30 15:32:03 +02:00
swarm.go fix(cmds): cleanup unicode identify strings (#9465) 2025-09-19 04:46:38 +02:00
sysdiag.go repo: use config api to get node root path (#10934) 2025-09-02 13:13:01 -07:00
version.go feat: Add CI for Spell Checking (#10637) 2025-01-30 17:50:51 +01:00