Matt Bell
57c48adfcf
commands/http: Made MultiFileReader thread safe
2014-11-18 02:13:57 -08:00
Matt Bell
c14bd98f7a
commands/http: Added MultiFileReader test
2014-11-18 02:13:57 -08:00
Matt Bell
8900229579
commands/http: Made MultiFileReader#Read more readable
2014-11-18 02:13:56 -08:00
Matt Bell
c9abc6b546
commands/http: Documented MultiFileReader
2014-11-18 02:13:56 -08:00
Matt Bell
c598673b4c
commands/http: Documented MultiFileReader
2014-11-18 02:13:56 -08:00
Matt Bell
5614234d1d
commands/http: MultiFileReader: Removed extraneous condition when checking next file
2014-11-18 02:13:56 -08:00
Matt Bell
ce49541f13
commands/http: Ignore mediatype validation (only required for file args)
2014-11-18 02:13:55 -08:00
Matt Bell
9333c504c1
commands/cli,http: Make sure required file arguments are provided
2014-11-18 02:13:55 -08:00
Matt Bell
f8be26810a
commands: Changed Request#Arguments to a []string
2014-11-18 02:13:55 -08:00
Matt Bell
51bfe06f1a
commands/http: Support recursive multipart in MultiFileReader
2014-11-18 02:13:54 -08:00
Matt Bell
132e740257
commands/http: Send req.Files() as multipart
2014-11-18 02:13:53 -08:00
Matt Bell
53735263c2
commands/http: Parse multipart files into req.Files()
2014-11-18 02:13:53 -08:00
Matt Bell
4b9fa9c97c
commands/http: Use constants for header names
2014-11-18 02:13:53 -08:00
Matt Bell
fdb71eb5dc
commands: Added MultiFileReader (read a File as multipart data)
2014-11-18 02:13:53 -08:00
Matt Bell
d1c50972f5
commands: Check for option errors when constructing Requests
2014-11-16 18:01:06 -08:00
Matt Bell
231960e726
commands/http: Fixed client erroring on nil command output
2014-11-14 03:20:11 -08:00
Matt Bell
28306a49c4
commands/cli,http: Properly preserve argument value count when checking argument validity
2014-11-14 03:20:04 -08:00
Brian Tiger Chow
c46102cec5
fix(commands/http/handler) check if found
...
@mappum, could you CR this and let me know if I've interpreted the
desired behavior correctly?
2014-11-14 03:19:57 -08:00
Brian Tiger Chow
71e92dace2
explain(commands/http)
...
we've gotta allow the code to speak for itself. I wouldn't have been
able to safely modify this code without having my hand held. I am but a
lowly programmer with a simple mind.
cc @jbenet @whyrusleeping @mappum
2014-11-14 03:19:57 -08:00
Matt Bell
a4e68c241b
commands/http: Get string representations of option values when creating querystring
2014-11-14 03:19:57 -08:00
Juan Batiz-Benet
49792b2362
refactored cast errors to use a util
2014-11-14 03:19:56 -08:00
Matt Bell
f93b806d21
commands/http: s/lenRequired/numRequired/
2014-11-14 03:17:40 -08:00
Matt Bell
3e507f7c9f
commands: Changed option accessor API (Request#Option now returns an OptionValue)
2014-11-14 03:17:38 -08:00
Matt Bell
eebb43753b
commands: Added list of option definitions to Request, so Option can lookup values by all aliases
2014-11-14 03:17:37 -08:00
Matt Bell
f1c788d710
commands/http: Don't set Content-Type for stream outputs so browsers can MIME-sniff the actual content type
2014-11-14 03:17:35 -08:00
Matt Bell
3df5202f8a
commands/http: Log incoming requests (with DEBUG log level)
2014-11-14 03:17:30 -08:00
Matt Bell
cb72868ab4
commands: Fixed parser argument bug (TODO: better test coverage for command parsers)
2014-11-14 03:17:28 -08:00
Matt Bell
83cda2e699
commands/http: Fixed arg parse bug
2014-11-14 03:17:27 -08:00
Matt Bell
37f05a8bf6
commands: Ensure argument parsing maintains total argument count, so that argument validation will fail if there are too many
2014-11-14 03:17:27 -08:00
Matt Bell
116041c5ec
commands: Fixed argument value/definition mapping
2014-11-14 03:17:26 -08:00
Brian Tiger Chow
d3f9aadd3e
fix(commands/http/client) cast safely
2014-11-05 10:15:17 -08:00
Matt Bell
1b9b60331f
commands/http: Cleaned up argument handling in Parse
2014-11-04 02:04:51 -08:00
Matt Bell
df6c700426
commands/http: Renamed variable for clarity
2014-11-04 02:04:51 -08:00
Matt Bell
c8ae4b6f42
commands/http: Decomposed Client#Send function
2014-11-04 02:04:51 -08:00
Matt Bell
e57cd9b857
commands/http: Use net/url querystring encoder
2014-11-04 02:04:51 -08:00
Matt Bell
33b0990a3a
commands/http: Cleaner URL formation in client
2014-11-04 02:04:51 -08:00
Matt Bell
5e5d534eb3
commands/http: Refactored API to a Client object that takes a string address
2014-11-04 02:04:50 -08:00
Matt Bell
f76048f74b
commands/http: Unexported Handler fields and created constructor
2014-11-04 02:04:50 -08:00
Matt Bell
4552fce517
commands/http: Respond with error if encoding option isn't a string
2014-11-04 02:04:50 -08:00
Matt Bell
446acdcdb5
commands/http: Ensure request URLs start with expected prefix
2014-11-04 02:04:50 -08:00
Matt Bell
f6c38882f0
commands: Return a reader in a Response#Reader method, instead of making Response implementing io.Reader
2014-11-04 02:04:49 -08:00
Matt Bell
69a56de040
commands: Renamed Response#Value to Response#Output
2014-11-04 02:04:49 -08:00
Matt Bell
75649f3d49
commands: Moved argument checking into a Command method, fail early when parsing commands
2014-11-04 02:04:49 -08:00
Matt Bell
405cfd9762
commands/http: Made parser/client handle variadic arguments
2014-11-04 02:04:49 -08:00
Matt Bell
ee2c76992a
commands/cli: Open argument files when creating Requests (Moved out of HTTP client)
2014-11-04 02:04:48 -08:00
Matt Bell
40858b43ed
commands/http: Added stream argument handling to client and request parser
2014-11-04 02:04:48 -08:00
Matt Bell
3a8d60cc61
commands: Removed inpout stream from Request
2014-11-04 02:04:48 -08:00
Matt Bell
827f1dd0b0
commands: Changed Request arguments to a []interface{}
2014-11-04 02:04:48 -08:00
Matt Bell
83b2ba00e9
commands: Removed Command#Private field
2014-11-04 02:04:48 -08:00
Matt Bell
cfa56dde82
commands/http: Error if trying to run private command
2014-11-04 02:04:47 -08:00
