Jeromy
082c147bbe
should fix issue where 'read on closed body' error was leaking down
...
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2015-07-29 13:26:39 -07:00
Jeromy
0c4b10afb2
comment need for custom client
...
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2015-07-27 15:19:43 -07:00
Jeromy
23d41e0823
address comments from CR and fix random failures
...
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2015-07-27 09:30:52 -07:00
Jeromy
1ce310be8b
some commenting
...
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2015-07-26 11:28:53 -07:00
Jeromy
fd75b64630
refactor http client code
...
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2015-07-25 19:56:45 -07:00
Jeromy
a7e50f1fbc
implement http trailers for errors after headers are sent
...
refactor http handler and copyChunks to get this all to work correctly
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2015-07-25 11:07:31 -07:00
Jeromy
8286abaf8c
attempt at properly closing http response bodies
...
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2015-07-22 13:31:33 -07:00
Jeromy
5873aa2aaa
if no context set in request, use context.TODO()
...
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2015-07-20 21:46:51 -07:00
Jeromy
bb3a75aa08
remove context from context
...
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2015-07-20 20:53:06 -07:00
Tor Arne Vestbø
cc45e21e4c
Teach http client to abort channel streaming on context cancellation
...
When the response includes the X-Chunked-Output header, we treat that
as channel output, and fire up a goroutine to decode the chunks. This
routine need to look for context cancellation so that it can exit
cleanly.
2015-04-20 16:35:35 +02:00
Tor Arne Vestbø
661fb0a4b5
Teach http client to cancel request on context cancellation
...
The context may be cancelled while a request is in flight. We need to
handle this and cancel the request. The code is based on the ideas
from https://blog.golang.org/context
2015-04-20 16:35:35 +02:00
Ho-Sheng Hsiao
bf22aeec0a
Reorged imports from jbenet/go-ipfs to ipfs/go-ipfs
...
- Modified Godeps/Godeps.json by hand
- [TEST] Updated welcome docs hash to sharness
- [TEST] Updated contact doc
- [TEST] disabled breaking test (t0080-repo refs local)
2015-03-31 12:52:25 -07:00
Juan Batiz-Benet
4334f6fda3
Merge pull request #613 from jbenet/progress-bars
...
Progress Bars
2015-01-23 22:20:34 -08:00
Matt Bell
5589021a1d
commands/http: Fixed panics when unmarshaling command output without a set Command.Type
2015-01-23 19:11:56 -08:00
Matt Bell
6adebfad11
commands: Added Length field to Response
...
squash! commands: Added Length field to Response
commands/http: client: Fixed error on unset length
2015-01-23 18:29:29 -08:00
Matt Bell
31ae178078
commands: Support outputting <-chan interface{}
2015-01-21 04:28:02 +00:00
Brian Tiger Chow
5b3164de5c
refactor(repo/config) move config under repo
2015-01-13 03:09:30 -08:00
Matt Bell
77e5742ac7
commands/http: client: Decode values into a new instance of the output type
2015-01-06 15:53:49 -08:00
Matt Bell
ecc2248aa0
commands/http: client: Fixed decoding values in channel output
2015-01-06 15:53:49 -08:00
Matt Bell
981f793df9
commands: Use a flag to enable streaming channel output
2015-01-06 15:53:48 -08:00
Matt Bell
5d3bc652cb
commands/http: client: Close output channel on decoder EOF
2015-01-06 15:53:48 -08:00
Matt Bell
cf1e770e1e
commands/http: Client: decode chunked streaming output
2015-01-06 15:53:48 -08:00
Matt Bell
5cb39235cc
commands/http: Fixed bug with client arg querystring
2014-12-05 20:56:27 -08:00
Matt Bell
4c7a694409
commands/http: Fixed client panic when sending a Request with nil 'Files'
2014-12-05 20:56:27 -08:00
Matt Bell
f8be26810a
commands: Changed Request#Arguments to a []string
2014-11-18 02:13:55 -08:00
Matt Bell
51bfe06f1a
commands/http: Support recursive multipart in MultiFileReader
2014-11-18 02:13:54 -08:00
Matt Bell
132e740257
commands/http: Send req.Files() as multipart
2014-11-18 02:13:53 -08:00
Matt Bell
231960e726
commands/http: Fixed client erroring on nil command output
2014-11-14 03:20:11 -08:00
Brian Tiger Chow
71e92dace2
explain(commands/http)
...
we've gotta allow the code to speak for itself. I wouldn't have been
able to safely modify this code without having my hand held. I am but a
lowly programmer with a simple mind.
cc @jbenet @whyrusleeping @mappum
2014-11-14 03:19:57 -08:00
Matt Bell
a4e68c241b
commands/http: Get string representations of option values when creating querystring
2014-11-14 03:19:57 -08:00
Juan Batiz-Benet
49792b2362
refactored cast errors to use a util
2014-11-14 03:19:56 -08:00
Matt Bell
3e507f7c9f
commands: Changed option accessor API (Request#Option now returns an OptionValue)
2014-11-14 03:17:38 -08:00
Matt Bell
f1c788d710
commands/http: Don't set Content-Type for stream outputs so browsers can MIME-sniff the actual content type
2014-11-14 03:17:35 -08:00
Brian Tiger Chow
d3f9aadd3e
fix(commands/http/client) cast safely
2014-11-05 10:15:17 -08:00
Matt Bell
df6c700426
commands/http: Renamed variable for clarity
2014-11-04 02:04:51 -08:00
Matt Bell
c8ae4b6f42
commands/http: Decomposed Client#Send function
2014-11-04 02:04:51 -08:00
Matt Bell
e57cd9b857
commands/http: Use net/url querystring encoder
2014-11-04 02:04:51 -08:00
Matt Bell
33b0990a3a
commands/http: Cleaner URL formation in client
2014-11-04 02:04:51 -08:00
Matt Bell
5e5d534eb3
commands/http: Refactored API to a Client object that takes a string address
2014-11-04 02:04:50 -08:00
Matt Bell
69a56de040
commands: Renamed Response#Value to Response#Output
2014-11-04 02:04:49 -08:00
Matt Bell
405cfd9762
commands/http: Made parser/client handle variadic arguments
2014-11-04 02:04:49 -08:00
Matt Bell
ee2c76992a
commands/cli: Open argument files when creating Requests (Moved out of HTTP client)
2014-11-04 02:04:48 -08:00
Matt Bell
40858b43ed
commands/http: Added stream argument handling to client and request parser
2014-11-04 02:04:48 -08:00
Matt Bell
3a8d60cc61
commands: Removed inpout stream from Request
2014-11-04 02:04:48 -08:00
Matt Bell
827f1dd0b0
commands: Changed Request arguments to a []interface{}
2014-11-04 02:04:48 -08:00
Matt Bell
abcebb0bc2
commands/http: Improved client error handling
2014-11-04 02:04:47 -08:00
Matt Bell
c0a9871d48
commands/http: Made HTTP client unmarshal response values based on the Command#Type
2014-11-04 02:04:46 -08:00
Matt Bell
32a2959348
commands/http: Don't try to parse HTTP response into a Response, just read the output
2014-11-04 02:04:46 -08:00
Matt Bell
42633e5d40
commands/http: Send request arguments in client requests
2014-11-04 02:04:45 -08:00
Matt Bell
48bd73c530
commands/http: Made client load RPC host from config
2014-11-04 02:04:45 -08:00