Brian Tiger Chow
ee378e2fbd
fix(test) tour content struct now exists
...
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
2014-11-14 03:31:06 -08:00
Juan Batiz-Benet
fa8fc1aefc
cmds2: check for updates
2014-11-14 03:20:46 -08:00
Matt Bell
1abe97617e
main: Pass Stdin to CLI request parser
2014-11-14 03:20:11 -08:00
Brian Tiger Chow
8b07b35467
ignore binary
...
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
2014-11-14 03:20:09 -08:00
Juan Batiz-Benet
e0ba14c0eb
cmds2: use cmdDetails on level cmds
2014-11-14 03:20:09 -08:00
Brian Tiger Chow
0eeed7cc68
add string method to command details
...
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
2014-11-14 03:20:09 -08:00
Brian Tiger Chow
65eb1d86fa
rm todos
...
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
2014-11-14 03:20:08 -08:00
Brian Tiger Chow
476aab9552
rm unused tests
...
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
2014-11-14 03:20:08 -08:00
Brian Tiger Chow
1065ae45aa
s/number/id "the id of the topic you'd like to tour"
...
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
2014-11-14 03:20:08 -08:00
Brian Tiger Chow
f1c20b4e3a
don't use the marshaler
...
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
2014-11-14 03:20:08 -08:00
Brian Tiger Chow
35da357dc5
fix(tour) patch up and verify tour output
...
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
2014-11-14 03:20:07 -08:00
Brian Tiger Chow
c99e9e6000
feat(details) add funcs to negate negations
...
not immediately useful, but nice to have
tagging you to make sure i didn't make a mistake here @jbenet
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
2014-11-14 03:20:07 -08:00
Brian Tiger Chow
5c4fa5a783
feat(tour) show list of topics when user tries to view topic that doesn't exist
...
eg.
```
ipfs2 (cmd-ref-part2) λ. go build ./...; ./ipfs2 tour 0
Tour 0 - Hello Mars
Hello Mars
ipfs2 (cmd-ref-part2) λ. go build ./...; ./ipfs2 tour 10
ERROR
no topic with id: 10
TOPICS
0 - Hello Mars
0.1 - Hello Mars 2
```
2014-11-14 03:20:07 -08:00
Juan Batiz-Benet
afa5eedb44
cmds2: commandShouldRunOnDaemon
...
This commit adds the pretty-complicated decision function
to check whether a command should run on the daemon.
@maybebtc @mappum double check the logic?
2014-11-14 03:20:07 -08:00
Juan Batiz-Benet
bb8d4ebd6b
cmds2: cmdDetailsMap
2014-11-14 03:20:07 -08:00
Brian Tiger Chow
ca2828f33c
feat(commands) add ClientError(msg) helper and use it to return a fancy error to the client in the tour
...
@jbenet this exists now
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
2014-11-14 03:20:07 -08:00
Brian Tiger Chow
c5e75f91a6
tests(2/main) errClient
...
Discovered this quirk about interfaces.
@whyrusleeping
@mappum
@jbenet
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
2014-11-14 03:20:07 -08:00
Brian Tiger Chow
0a93f9d764
style(tour) newline at the end
...
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
2014-11-14 03:20:06 -08:00
Matt Bell
db361d9403
commands/cli: Made Parse return an error if request has unrecognized options
2014-11-14 03:20:06 -08:00
Matt Bell
815efdb125
daemon: Added a ShortDescription
2014-11-14 03:20:06 -08:00
Brian Tiger Chow
ff6c4ce6a4
test(tour) ensure template renders without failure
...
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
2014-11-14 03:20:06 -08:00
Juan Batiz-Benet
047d2e2d62
cmd2: Marshaller -> Marshaler (see golang/encoding)
...
Also:
- map[cmds.EncodingType]cmds.Marshaller -> MarshalMap
cc @mappum @maybebtc
2014-11-14 03:20:05 -08:00
Matt Bell
c973776049
main: Fixed logical error in remote/local check
2014-11-14 03:20:05 -08:00
Matt Bell
e700b16576
Ported remaining command helptext to HelpText struct
2014-11-14 03:20:05 -08:00
Matt Bell
b4735eb10b
main: Test if commands are local-only when choosing daemon vs. local
2014-11-14 03:20:04 -08:00
Matt Bell
188bf779db
Removed cmdInvocation.root
2014-11-14 03:20:03 -08:00
Matt Bell
9afb85714a
commands/cli: Don't return root in Parse
2014-11-14 03:20:03 -08:00
Matt Bell
b7b15b8b30
cmd/ipfs2: Added isLocal function for testing if a command is local only
2014-11-14 03:20:03 -08:00
Matt Bell
2dd6f24157
core/commands2: Refactored some commands to HelpText struct for helptext fields
2014-11-14 03:20:03 -08:00
Matt Bell
2fd8f39c65
cmd/ipfs2: Added comments to explain purpose of CLI root
2014-11-14 03:20:03 -08:00
Juan Batiz-Benet
7daf888902
cmds2: handle error return codes
2014-11-14 03:20:03 -08:00
Juan Batiz-Benet
d18902df27
cmds2: changed how the ctx.Node works
2014-11-14 03:20:02 -08:00
Juan Batiz-Benet
3352aeee15
cmds2: fixed show help on root + noncallable
2014-11-14 03:20:02 -08:00
Juan Batiz-Benet
f738e899c2
cmd2: simplified main
...
Attention @maybebtc @mappum
I cleaned up + simplified the main flow. Now, all printing
is contained inside main itself! (:cheer:). I do this with
the help of a cmdInvocation struct that has both
a Parse and Run. The only major clunkiness left is that the
"CallCommand" is still its own function. But *shrug*.
Please test it works as we would expect. i changed much of
the flow, so likely that i missed a complicated edge case.
main roadmap:
- parse the commandline to get a cmdInvocation
- if user requests, help, print it and exit.
- run the command invocation
- output the response
- if anything fails, print error, maybe with help
2014-11-14 03:20:02 -08:00
Matt Bell
092524fcbb
cmd/ipfs2: Added a 'commands' command for CLI root
2014-11-14 03:20:01 -08:00
Matt Bell
fd8b1930af
cmd/ipfs2: Copy subcommands from core/commands2 root into cmd/ipfs2 root
2014-11-14 03:20:01 -08:00
Brian Tiger Chow
4e740f63eb
docs(ipfs2/main)
...
@mappum
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
2014-11-14 03:20:01 -08:00
Brian Tiger Chow
22a4cc7d30
fix(ipfs2) output info to logger when checking daemon status
2014-11-14 03:20:01 -08:00
Juan Batiz-Benet
a2d06b5f9a
cmds2: errHelpRequested error
2014-11-14 03:20:01 -08:00
Matt Bell
78bc748342
cmd/ipfs: Fixed bug where handleParseError sets error to nil
2014-11-14 03:19:59 -08:00
Juan Batiz-Benet
ec8be23cbc
cmds/main decomposed handleParseError
2014-11-14 03:19:59 -08:00
Brian Tiger Chow
7060e7dfe2
rename variable
2014-11-14 03:19:58 -08:00
Brian Tiger Chow
fed2f8d2c6
fix(2/main) option value signature
2014-11-14 03:19:58 -08:00
Brian Tiger Chow
013d98a35a
fix(2/init, 2/add) fix optionvalue signature
2014-11-14 03:19:58 -08:00
Matt Bell
7a505b44c7
Handle -h and --help differently (short text vs long text)
2014-11-14 03:17:42 -08:00
Matt Bell
c76a52e422
cmd/ipfs2: Show short help text instead for usage errors
2014-11-14 03:17:42 -08:00
Matt Bell
4970d8b5a3
commands/cli: Use template for helptext generation
2014-11-14 03:17:41 -08:00
Matt Bell
e23b537f32
Override root command help text
2014-11-14 03:17:41 -08:00
Matt Bell
b358bb3ffd
cmd/ipfs2: Added comment to explain default encoding logic
2014-11-14 03:17:40 -08:00
Matt Bell
aea2fce987
cmd/ipfs2: Added explanation comment to ipfsHandler
2014-11-14 03:17:40 -08:00