Use PingResult errors for errors attached to individual pings.
This is a (minor) BREAKING CHANGE.
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
We do this _just_ to make the error nicer but it's really slow. Additionally, we
do it while holding the pin lock, blocking all other pin operations.
fixes#6295
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Updated docs to reflect that Routing is not a child of Discovery
Ref. 664ccd976e/routing.go (L6)
License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
This series of commits aims to update go-ipfs to follow a dual-licensing best practice based on research into open-source licensing by @ianjdarrow. He recommends a dual MIT and Apache 2.0 license -
> This has two major benefits:
> - There are concerns in the open source community about whether the MIT license leaves users vulnerable to patent infringement claims. We think the pure legal risk is small, but the way the open source community interacts with our project is really important. It makes sense to pick the license that makes the largest number of people comfortable.
- There's now no reason to adopt a separate DCO, since the Apache-2 license grant addresses the same issue.
> Why use a dual license, instead of just Apache-2? The Apache-2 license is incompatible with the GPLv2 license, which includes things like the Linux kernel. With a dual license, GPLv2 projects can just use the MIT license instead. Our goal is to make our software available to as many projects as possible, so we'd rather adopt a licensing scheme that doesn't exclude anyone.
In addition to these commits, we also need to get an explicit OK from current and past contributors to give their consent to relicensing - which will happen in an issue thread.
In TestExternalUnmount, the Mount function is called which returns an
error which can be nil. The error type is then used in a comparison
where Error() is called on it. If the error is nil, this results in a
panic.
Added a if err != nil {} guard to make sure that Error() is not called
if the value is nil
On branch go-test-fix
Changes to be committed:
modified: fuse/node/mount_test.go
License: MIT
Signed-off-by: Chris Buesser <christopher.buesser@gmail.com>
This commit fixes the errors resulting from passing a nil pointer to the
core.NewNode function in TestExternalUnmmount and setupIpnsTest.
In the previous nil's place a &core.BuildCfg{} is now passed.
Both changes follow the same pattern:
```diff
- node, err = core.NewNode(context.Background(), nil)
+ node, err = core.NewNode(context.Background(), &core.BuildCfg{})
```
On branch go-test-fix
Changes to be committed:
modified: fuse/ipns/ipns_test.go
modified: fuse/node/mount_test.go
License: MIT
Signed-off-by: Chris Buesser <christopher.buesser@gmail.com>
The usage of a native 'go' command has been replaced with a make &
environment variable $GOCC. This enables building with multiple go
versions on a single machine as documented:
* https://golang.org/doc/install#extra_versions
This enables the usage of:
```bash
$ make install
$ # OR
$ GOCC=go1.12.3 make install
$ # OR
$ GOCC=go1.12.4 make install
```
And the build and test tools now pick up on this change
On branch go-version-check
Changes to be committed:
modified: Rules.mk
modified: bin/check_go_version
modified: bin/dist_get
modified: bin/maketarball.sh
modified: coverage/Rules.mk
modified: mk/golang.mk
modified: mk/tarball.mk
License: MIT
Signed-off-by: Chris Buesser <christopher.buesser@gmail.com>
We were canceling the context in `GarbageCollect` but some functions call `GC`
directly. Move the context cancelation down to where we actually _need_ it.
fixes#6279
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
tweak the daemon --help output to use escaped double quotes instead
of single quotes so the same command can be used on windows.
fixes: #2034
License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
Otherwise, it seems that something is treating this as UTF8 and normalizing it?
fix half of #3124
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
