Commit Graph

83 Commits

Author SHA1 Message Date
Steven Allen
70bf571742 bump tar dep to make it resolvable
It wasn't pinned and `gx publish -f` gave a different hash.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-03-23 10:53:55 -07:00
Whyrusleeping
1fb90ad62c
Merge pull request #4857 from ipfs/extract/thirdparty-tar
Extract: thirdparty/tar
2018-03-23 09:41:31 -07:00
Whyrusleeping
aaf6ee78cc
Merge pull request #4809 from djdv/fix/get/outpath
Fix get output path
2018-03-22 23:29:17 -07:00
Hector Sanjuan
9a2f2976f2 Use latests tar-utils
License: MIT
Signed-off-by: Hector Sanjuan <hector@protocol.ai>
2018-03-22 00:28:44 +01:00
Hector Sanjuan
5bbaa75bea Extract: thirdparty/tar
This module was sort of extracted to whyrusleeping/tar-utils long ago.
I gxed that, imported commits from go-ipfs to the current state, and
extracted it.

License: MIT
Signed-off-by: Hector Sanjuan <hector@protocol.ai>
2018-03-21 18:02:25 +01:00
Steven Allen
7824c2cf4e check arguments after handling help
otherwise, we block on required arguments from stdin before processing the help
flag.

fixes #4837

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-03-19 15:58:34 -07:00
Steven Allen
45fd7d213f pre-populate required arguments from request body
This way, we can always assume that indexing a required argument works.

Also:

* test that the command tree doesn't have any obvious bugs (duplicate options,
  arguments in the wrong order, etc).
* simplify the usage ParseBodyArgs.
* remove unnecessary check in the get command.

fixes #4823

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-03-18 13:04:25 -07:00
Dominic Della Valle
dcd7e6c187 Fix get output path
Minor but important change for platform native output paths

License: MIT
Signed-off-by: Dominic Della Valle <ddvpublic@gmail.com>
2018-03-12 10:44:31 -04:00
Steven Allen
45756b6d64 fix a bunch of go vet errors
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-02-20 17:37:35 -08:00
Steven Allen
2c68c15407 update go-ipfs-cmds
* May fix #4670
* Fixes #4683

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-02-20 16:43:00 -08:00
Steven Allen
b2cbfd299c gx: update go-log
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-31 21:54:22 -08:00
Steven Allen
5acbecc26b update go-lib2p-loggables
fixes a UUID bug I introduced (UUIDs were always an error value)

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-27 18:05:30 -08:00
Steven Allen
fe8846fcd7 gx: mass update
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-24 15:58:44 -08:00
Steven Allen
fcef972cda restore call to getOutPath function
It strips the last `/` which was part of a partial fix for #3729. Unfortunately,
it's not a *real* fix but we might as well leave this as it is until we
completely fix it.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-23 12:13:37 -08:00
Steven Allen
2f964d40e8 forbid bad compression levels
(instead of allowing -1 and treating it as "use default")

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-23 11:55:04 -08:00
Jeromy
176d15656d update go-ipfs-cmds, fix context closing issue
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2018-01-21 11:11:47 -08:00
Steven Allen
0bdc2574ce update go-ipfs-cmds
Fix a nil pointer exception when no timeout is set and an HTTP request fails.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-21 11:11:47 -08:00
Steven Allen
cddef3ec5e use PostRunMap when constructing PostRun in commands
Writing out the full type explicitly is ugly and verbose.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-21 11:11:47 -08:00
Jeromy
bf804cca66 update to final cmds1.0
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2018-01-21 11:11:47 -08:00
Jeromy
267c19ab9d some fixes for latest from go-ipfs-cmds
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2018-01-21 11:11:47 -08:00
keks
091eeee243 update go-ipfs-cmds
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
keks
1cc7e2a28e update go-ipfs-cmds
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
keks
7b1963906b update go-ipfs-cmds yet again
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
keks
b23c3295e6 update go-ipfs-cmds
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
keks
94266bf2e4 update go-ipfs-cmds
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
keks
fbc36b8962 update dependencies and update TODO
broken sharness test t0110 has been fixed in master

License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
keks
e8ad094448 add TODO
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
keks
feef5c3415 cmds: use Executors
- some fixes for cmds1.0
- reinsert plugin loading code, pretty print wrapper

TODO:
if plugin loading fails it only calls log.Warning.
returning an error would be better but that would have
to happen after PreRun, which is not possible atm.

License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
keks
84101c8a2a go test passes, sharness fails
pass API path to cmds, fix options in add.

License: MIT
Signed-off-by: keks <keks@cryptoscope.com>
2018-01-21 11:11:47 -08:00
keks
bd9576fa57 start adopting cmds3.0 - lots of errors!
- move go-ipfs-cmds/legacy to go-ipfs/commands/legacy
- update cmds,cmdkit; go test ./... ok

License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
Steven Allen
dfe7ef4fcf gx: update go-multihash
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2017-12-14 13:09:51 -08:00
keks
6f82f08611 fix error handling in core/commands/{add,get}.go
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2017-12-04 14:27:34 +01:00
keks
8e5fbe9aa1 update go-ipfs-cmds to 0.4.11
to include @frist's uuid logging

License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2017-11-22 19:06:00 +01:00
Steven Allen
bcd25416d9 cmds: rename DefaultVal -> Default, Default -> WithDefault
Propagate change from cmdkit.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2017-11-20 22:20:49 -08:00
Steven Allen
76e1da02a8 gx: massive update
Note: This commit is technically broken. However, I need to make a bunch of
cmds changes to make this work and I'd rather not bundle both changes into a
single commit.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2017-11-20 22:20:27 -08:00
Lorenzo Manacorda
57f544a79c remove all instances of Default(false)
Boolean options always default to false.

License: MIT
Signed-off-by: Lorenzo Manacorda <lorenzo@mailbox.org>
2017-11-20 16:10:15 +01:00
adamliesko
a09d974652 core: get cmd outPath removes trailing slash - fixes #3729
When using path with trailing slashes, ipfs get command had issues
with trying to store content into '.' folder (as the file part of the path
was empty). Now, it correctly stores the file into desired folder,
thanks to the removal of trailing slash by introducing a
getOutPath function in get command, which does proper parsing
Of the output path.

BEFORE:
 $  .pfs get /ipns/multiformats.io/
Saving file(s) to .

NOW:
$ ./ipfs get /ipns/multiformats.io/
Saving file(s) to multiformats.io

License: MIT
Signed-off-by: adamliesko <adamliesko@gmail.com>
2017-11-18 20:04:18 +01:00
keks
d95a87cf57 update to go-ipfs-cmds 0.4.9
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2017-11-17 15:22:42 +01:00
keks
0d9d21875c compatible to js-ipfs-api
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2017-11-17 15:22:42 +01:00
Jan Winkelmann
f287524949 cmd: use go-ipfs-cmds
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2017-11-17 15:22:41 +01:00
Jakub Sztandera
66cc2f2e88
fix: ipfs get panic with empty API call
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2017-03-09 15:42:15 +01:00
Jeromy Johnson
eca0d1c734 Merge pull request #3757 from ipfs/fix/get-raw-leaves
make raw leaves work with 'ipfs get'
2017-03-07 15:40:18 -08:00
Jeromy
169f7899ba fix progress bar on ipfs get
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2017-03-06 22:59:10 -08:00
Jeromy
b1588c7162 make raw leaves work with 'ipfs get'
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2017-03-06 20:12:05 -08:00
Jeromy
67c2a4ec14 make path resolver no longer require whole node for construction
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
2016-10-25 15:04:44 -07:00
Jeromy
01aee44679 merkledag: change 'Node' to be an interface
Also change existing 'Node' type to 'ProtoNode' and use that most
everywhere for now. As we move forward with the integration we will try
and use the Node interface in more places that we're currently using
ProtoNode.

License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
2016-10-12 08:16:03 -07:00
Jeromy
5d301cb8ec re-enable the stdin
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
2016-07-08 16:39:15 -07:00
Jeromy
43cd49dcb4 fix progress bar in ipfs get
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
2016-07-06 15:42:08 -07:00
Thomas Gardner
ddc8d0c60c commands: remove EnableStdin support for StringArg
With verbose flag:
* remove EnableStdin() flags on all StringArg,

* remove all unneeded parsing code for StringArg, and print an
* informative message if `ipfs` begins reading from a CharDevice,

* remove broken go tests for EnableStdin cli parsing, and add some
* trivial test cases for reading FileArg from stdin,

* add a panic to prevent EnableStdin from being set on
* StringArg in the future.

Resolves: #2877, #2870
License: MIT
Signed-off-by: Thomas Gardner <tmg@fastmail.com>
2016-06-26 12:28:55 +10:00
Jeromy Johnson
fd1eae87f7 Merge pull request #2782 from ipfs/feature/78-ruler
All commands: Align to under 78-ruler width
2016-06-01 09:45:55 -07:00