Commit Graph

595 Commits

Author SHA1 Message Date
Steven Allen
7824c2cf4e check arguments after handling help
otherwise, we block on required arguments from stdin before processing the help
flag.

fixes #4837

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-03-19 15:58:34 -07:00
Steven Allen
45fd7d213f pre-populate required arguments from request body
This way, we can always assume that indexing a required argument works.

Also:

* test that the command tree doesn't have any obvious bugs (duplicate options,
  arguments in the wrong order, etc).
* simplify the usage ParseBodyArgs.
* remove unnecessary check in the get command.

fixes #4823

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-03-18 13:04:25 -07:00
Steven Allen
c24a08be2e delete dead code
This code was making it *really* hard to understand the commands code.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-03-16 20:34:36 -07:00
Steven Allen
ca3b8224f6 remove some dead code
(it was causing go vet to complain)

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-02-20 17:39:16 -08:00
Steven Allen
45756b6d64 fix a bunch of go vet errors
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-02-20 17:37:35 -08:00
Steven Allen
868855f625 fix legacy commands test for cmds lib changes
cmd.Call no longer returns an error

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-02-20 17:24:16 -08:00
Steven Allen
2c68c15407 update go-ipfs-cmds
* May fix #4670
* Fixes #4683

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-02-20 16:43:00 -08:00
Steven Allen
b2cbfd299c gx: update go-log
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-31 21:54:22 -08:00
Steven Allen
5acbecc26b update go-lib2p-loggables
fixes a UUID bug I introduced (UUIDs were always an error value)

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-27 18:05:30 -08:00
Steven Allen
fe8846fcd7 gx: mass update
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-24 15:58:44 -08:00
Steven Allen
31bb782e77 fix code-climate issues
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-23 20:04:45 -08:00
Steven Allen
e00f903c82 return background context instead of nil
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-23 11:54:39 -08:00
Jeromy
176d15656d update go-ipfs-cmds, fix context closing issue
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2018-01-21 11:11:47 -08:00
Steven Allen
0bdc2574ce update go-ipfs-cmds
Fix a nil pointer exception when no timeout is set and an HTTP request fails.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-21 11:11:47 -08:00
Steven Allen
652ac620b1 golint: documentation fixes
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-21 11:11:47 -08:00
Steven Allen
2e2996223f fix legacy tests
* remove test for removed feature
* fix `TestNewCommand` test.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2018-01-21 11:11:47 -08:00
Jeromy
bf804cca66 update to final cmds1.0
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2018-01-21 11:11:47 -08:00
Jeromy
267c19ab9d some fixes for latest from go-ipfs-cmds
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2018-01-21 11:11:47 -08:00
keks
091eeee243 update go-ipfs-cmds
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
keks
1cc7e2a28e update go-ipfs-cmds
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
keks
8f24d8e211 cleanup
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
keks
7b1963906b update go-ipfs-cmds yet again
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
keks
b23c3295e6 update go-ipfs-cmds
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
keks
94266bf2e4 update go-ipfs-cmds
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
keks
fbc36b8962 update dependencies and update TODO
broken sharness test t0110 has been fixed in master

License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
keks
23a27b9c67 fix test that didn't respect cmds.Single
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
keks
e8ad094448 add TODO
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
keks
feef5c3415 cmds: use Executors
- some fixes for cmds1.0
- reinsert plugin loading code, pretty print wrapper

TODO:
if plugin loading fails it only calls log.Warning.
returning an error would be better but that would have
to happen after PreRun, which is not possible atm.

License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
keks
84101c8a2a go test passes, sharness fails
pass API path to cmds, fix options in add.

License: MIT
Signed-off-by: keks <keks@cryptoscope.com>
2018-01-21 11:11:47 -08:00
keks
bd9576fa57 start adopting cmds3.0 - lots of errors!
- move go-ipfs-cmds/legacy to go-ipfs/commands/legacy
- update cmds,cmdkit; go test ./... ok

License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2018-01-21 11:11:47 -08:00
Steven Allen
973dead066 remove dead code
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2017-12-15 10:31:43 -08:00
Steven Allen
dfe7ef4fcf gx: update go-multihash
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2017-12-14 13:09:51 -08:00
Jeromy
68bb106980 Delete some now unused commands lib code
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2017-11-21 20:40:24 -08:00
Steven Allen
bcd25416d9 cmds: rename DefaultVal -> Default, Default -> WithDefault
Propagate change from cmdkit.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2017-11-20 22:20:49 -08:00
Steven Allen
76e1da02a8 gx: massive update
Note: This commit is technically broken. However, I need to make a bunch of
cmds changes to make this work and I'd rather not bundle both changes into a
single commit.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2017-11-20 22:20:27 -08:00
Whyrusleeping
b01e48a758
Merge pull request #4392 from ipfs/feat/log/uuid
Feat/log/uuid
2017-11-18 10:25:23 -08:00
Jan Winkelmann
f287524949 cmd: use go-ipfs-cmds
License: MIT
Signed-off-by: keks <keks@cryptoscope.co>
2017-11-17 15:22:41 +01:00
Forrest Weston
f44cf00342 Add error message to event logs in path resolution
If an error occurs during an event add it to the events metadata

License: MIT
Signed-off-by: Forrest Weston <forrest@protocol.ai>
2017-11-15 12:27:22 -08:00
Forrest Weston
846c04b131 Added uuid loggable (requestId) to root context
Every log event resulting from a command will have a uuid associated with it

License: MIT
Signed-off-by: Forrest Weston <forrest@protocol.ai>
2017-11-14 18:02:15 -08:00
Łukasz Magiera
1a93abcd69 fix 'file already closed' in Go 1.9
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
2017-08-20 23:23:55 +02:00
Jeromy
cccc6a94a3 update go-multihash and bubble up changes
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2017-07-11 19:27:43 -07:00
zramsay
096b3232d5 address PR comments; remove commented/dead code
License: MIT
Signed-off-by: Zach Ramsay <zach.ramsay@gmail.com>
2017-06-01 12:13:04 -04:00
zramsay
c5df8f0796 apply the megacheck tool to improve code quality
License: MIT
Signed-off-by: Zach Ramsay <zach.ramsay@gmail.com>
2017-05-31 16:56:11 -04:00
Jeromy
b15470d548
bubble up updates from go-multihash changes
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2017-04-20 20:28:04 +02:00
keks
8ee7aa5cab commands: restore and test original error order
License: MIT
Signed-off-by: Jan Winkelmann <j-winkelmann@tuhh.de>
2017-04-05 11:57:54 +02:00
Jeromy
4a86b7b6b9 fix hidden file detection on windows
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2017-03-24 12:21:43 -07:00
Jeromy Johnson
ff997c1f7a Merge pull request #3824 from ipfs/fix/govet/some-error
fix: multiple govet warnings
2017-03-23 20:56:10 -07:00
Jeromy Johnson
ac69697bd9 Merge pull request #3042 from ipfs/feat/hamt-sharding
Implement unixfs sharding
2017-03-23 20:51:52 -07:00
Jakub Sztandera
6546aeade7
fix: multiple govet warnings
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2017-03-24 01:02:50 +01:00
Jeromy Johnson
2cc5ce45b8 Merge pull request #3777 from ipfs/fix/gateway-status-codes
Return 404 Not Found for failed path resolutions
2017-03-22 22:31:54 -07:00