coosld/kubo
1
0
Fork 0
mirror of https://github.com/ipfs/kubo.git synced 2026-02-26 04:47:45 +08:00
Code Issues Actions 13 Packages Projects Releases Wiki Activity
3,368 Commits 161 Branches 212 Tags 122 MiB
6599756168
Commit Graph

346 Commits

Author SHA1 Message Date
Brian Tiger Chow
c00a7a2ebe misc(bitswap/strat) rm noisy message 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-13 05:43:27 -08:00
Brian Tiger Chow
cf43cdd5d8 feat(bs/testutil) use write cache 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-13 05:43:27 -08:00
Brian Tiger Chow
3ecdec985f refactor(mockrouting) misc 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-13 05:30:33 -08:00
Brian Tiger Chow
193004a061 refac(bs/test) provide a shared net delay constant 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-13 05:17:16 -08:00
Brian Tiger Chow
3c44ad1fd1 feat(bs/testnet) use delay in virtual network 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-13 05:17:16 -08:00
Brian Tiger Chow
8e0c8a7a7e refactor(mdag, bserv, bs) mocks, etc. 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-13 05:17:16 -08:00
Brian Tiger Chow
1c8acd01c9 fix(bs/testnet) rm named error 
Real version doesn't expose this

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-13 05:17:16 -08:00
Brian Tiger Chow
74eb03231d fix(core, peer) helpers to testutil, err handling 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-08 14:32:52 -08:00
Brian Tiger Chow
d77c4bb5e0 refactor(peer): create peer through peerstore 
for safety!

use mockpeer.WithID methods to create peers in tests

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-08 02:10:42 -08:00
Jeromy
e22ef19d84 log when dupe block is prevented 2014-12-07 21:03:54 +00:00
Jeromy
e4a8a2ed65 same block cant be sent twice to a peer within a certain time period 2014-12-07 20:54:31 +00:00
Jeromy
39162f2cea prevent sending of same block to a peer twice 2014-12-07 07:54:44 +00:00
Brian Tiger Chow
ab565474ca rm unnecessary concurrency 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 23:33:32 -08:00
Brian Tiger Chow
601a2faa28 move public method to top of file 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 23:33:30 -08:00
Brian Tiger Chow
9a2f79c42f refactor(bitswap) consolidate HasBlock 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

Conflicts:
	exchange/bitswap/bitswap.go
 2014-12-05 23:32:21 -08:00
Brian Tiger Chow
670d0244b4 feat(bitswap) make offline exchange query datastore 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 23:31:01 -08:00
Jeromy Johnson
260ac96175 Update README.md 2014-12-05 20:53:36 +00:00
Jeromy
afa28dc672 update bitswap readme 2014-12-05 20:53:36 +00:00
Jeromy
f054be9e1f update bitswap readme 2014-12-05 20:53:35 +00:00
Jeromy
6552163740 add readme for bitswap 2014-12-05 20:53:33 +00:00
Jeromy
432eee651f remove unnecessary concurrency in last commit 2014-12-05 20:53:33 +00:00
Jeromy
e8536db351 make bitswap sub-RPC's timeout (slowly for now) 2014-12-05 20:53:33 +00:00
Jeromy
c2b497e315 switch over to using sendMessage vs sendRequest 2014-12-05 20:53:32 +00:00
Jeromy
3a6b6c6974 cleanup, use a workgroup over channels 2014-12-05 20:53:32 +00:00
Brian Tiger Chow
9835c1e335 doc(bitswap) fix duplicaduplication 
@whyrusleeping

ada571425b (commitcomment-8753622)

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:32 +00:00
Jeromy
bc02b77b47 document bitswap more 2014-12-05 20:53:32 +00:00
Jeromy
f0a4fdad59 some bitswap cleanup 2014-12-05 20:53:32 +00:00
Brian Tiger Chow
1e7b7efa76 refactor(bitswap) perform Publish in HasBlock 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:32 +00:00
Brian Tiger Chow
829eac3012 fix(bitswap) pass derived context to called functions 
@whyrusleeping @jbenet

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:31 +00:00
Brian Tiger Chow
bb0b5f7c0b fix(notifications) prevent deadlock when context cancelled early 
+ test(notifications)

cc @whyrusleeping @jbenet

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:31 +00:00
Brian Tiger Chow
7a3819a528 refactor(util) move block generator 
@whyrusleeping @jbenet

Putting the block generator in a util dir until blocks.

Can't put it in util/testutil because the util/testutil/dag-generator
imports blockservice and blockservice uses the generator.

Tough problem. This'll do for now.

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:31 +00:00
Jeromy
4cc1780705 fix issues in merkledag 2014-12-05 20:53:31 +00:00
Brian Tiger Chow
bef75d5061 fix(bitswap/testutils) vendor 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:30 +00:00
Brian Tiger Chow
fb5779661b fix(bs/notifications) use SubOnceEach to provide uniqueness guarantee 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

vendor forked pubsub to get SubOnceEach

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:30 +00:00
Brian Tiger Chow
19de3041fb fix(bitswap) build-breaking compilation errors 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:30 +00:00
Jeromy
07bb901ed5 add a test to blockservice to demonstate GetBlocks failure. 2014-12-05 20:53:29 +00:00
Jeromy
6d217b5311 ensure sending of wantlist to friendly peers 2014-12-05 20:53:29 +00:00
Brian Tiger Chow
9bf1ba6ab5 fix(bs/notifications) prevent duplicates 
@whyrusleeping now notifications _guarantees_ there won't be any
duplicates

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:29 +00:00
Brian Tiger Chow
20382340f5 test(bs/n) check for duplicates received 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:29 +00:00
Brian Tiger Chow
6a5bc4b879 fix(bs/n) remove unnecessary variable 
to remove ambiguity

(before it was possible to loop over either topics or keys

by only keeping keys, there's no confusing about what to use for the
loop range

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:28 +00:00
Brian Tiger Chow
134929ac64 misc(bs/n) rm dead code 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:28 +00:00
Brian Tiger Chow
b3d3b1dd30 refactor(bitswap) forwardN no longer needed 
@whyrusleeping

now, the pubsub channel closes after sending N blocks. we got this
functionality for free from the fix. So, the forwardN wrap is no longer
required! woohoo

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:28 +00:00
Brian Tiger Chow
a5fccaccee tests(bitswap/notifications) test niladic 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:28 +00:00
Brian Tiger Chow
03324f7765 fix(bitswap/notifications) subscribe to many 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:28 +00:00
Brian Tiger Chow
1fb80330da docs(bitswap/notifications) 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:27 +00:00
Jeromy
50b00eb90f use @maybebtc's ForwardBlocks function 2014-12-05 20:53:27 +00:00
Brian Tiger Chow
d5e7fd6707 test(notifications) 
we expect this to fail. will be fixed in upcoming commit

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:27 +00:00
Jeromy
9120d107c3 a little more correctness on the new bitswap impl 2014-12-05 20:53:27 +00:00
Jeromy
ed4509923c tracking down a bug dhthell found, added asserts and better logging. 2014-12-05 20:53:26 +00:00
Jeromy
d53deebada wire GetBlocks into blockservice 2014-12-05 20:53:26 +00:00
Brian Tiger Chow
ab201c15bb test(bitswap) Close (but skip for now) 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:25 +00:00
Brian Tiger Chow
59a32b1d0f refactor(bitswap) group the deferreds 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:25 +00:00
Brian Tiger Chow
c7c085970e fix(exchange) allow exchange to be closed 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:25 +00:00
Brian Tiger Chow
4ef780a9c9 fix(bitswap) signal termination to async'ly spawned workers 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:25 +00:00
Brian Tiger Chow
5bd3b178b6 style(bitswap) name -> loop 
eh?

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:24 +00:00
Brian Tiger Chow
f6cb4ab9a2 feat(bitswap) loop over all provided keys 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:24 +00:00
Brian Tiger Chow
ecf62dbf3a feat(bitswap) find providers for all keys on wantlist 
@jbenet @whyrusleeping

this addresses a failure case where

1) bitswap wants blocks A and B
2) partner 1 has A and partner 2 has B
3) We choose a key at random, drawing A.
4) Then, we request A, neglecting to find a provider for B.

Sending the full wantlist is meant to be used as a helpful additional
piece of data, but...

unless our hunch is support by statistical inference at runtime,
it's not safe to assume that a peer will have blocks for related keys.
Routing must be the source of truth.

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:24 +00:00
Brian Tiger Chow
7c2053c3c8 fix(bitswap/loop) add to wantlist just once 
oops

set Add is idempotent but it's a waste of resources

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:24 +00:00
Brian Tiger Chow
04a8a6133c rename exchange 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:24 +00:00
Brian Tiger Chow
eb0bde052e rename 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:23 +00:00
Brian Tiger Chow
918c8e274e refactor(blockstore) mv under blocks/ 
@jbenet @whyrusleeping

the pyramids were built one brick at a time

addresses: https://github.com/jbenet/go-ipfs/issues/370

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:23 +00:00
Brian Tiger Chow
5babfb975d tests(bitswap) share code between the two large tests 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:23 +00:00
Brian Tiger Chow
a5754a5ff4 fix(bitswap) stop the ticker when the run loop exits 
@whyrusleeping

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:23 +00:00
Brian Tiger Chow
11f2856d31 feat(bitswap) implement GetBlocks 
@whyrusleeping @jbenet

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:22 +00:00
Brian Tiger Chow
b13a5a940b refactor(bitswap) move wantlist to loop receive 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:22 +00:00
Brian Tiger Chow
81a3ba0677 tests(bitswap) share constructor between tests 
@whyrusleeping i hope this makes it a bit easier to work with tests

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:22 +00:00
Brian Tiger Chow
8f8230823f feat(bitswap/notifications) Subscribe to multiple keys 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:22 +00:00
Brian Tiger Chow
85229be43a style(bitswap/notifications) make it more obvious 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:21 +00:00
Jeromy
297ff3d4b2 randomize rebroadcast target 2014-12-05 20:53:21 +00:00
Jeromy
19da05701d remove buffer timing in bitswap in favor of manual batching 2014-12-05 20:53:21 +00:00
Jeromy
e4b2ae3bb2 fix tests halting 2014-12-05 20:53:21 +00:00
Jeromy
0abc72c062 move some variables into strategy 2014-12-05 20:53:21 +00:00
Jeromy
4d1447589c added a new test for a dhthell scenario that was failing 2014-12-05 20:53:21 +00:00
Brian Tiger Chow
9af9ee6255 misc(bitswap) renaming 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:20 +00:00
Brian Tiger Chow
f8243c36be simplify 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:20 +00:00
Brian Tiger Chow
e5983cbe7d some renaming 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:20 +00:00
Brian Tiger Chow
6c2a6669cb constify to make it clear what _can_ and _can't_ change over time 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:20 +00:00
Brian Tiger Chow
3ee7ff54ba naming 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:20 +00:00
Brian Tiger Chow
7239036e2d clarify MessageReceived contract 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:19 +00:00
Brian Tiger Chow
5165fce9d9 use event logger here too? 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:19 +00:00
Brian Tiger Chow
5a4eed4c00 fix(log) ->f 
@whyrusleeping

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:19 +00:00
Brian Tiger Chow
768cd3682c fix(bitswap) consistent event names 
@whyrusleeping @jbenet

since the logger is created with package scope, don't need to specify
the package name in event messages

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:19 +00:00
Brian Tiger Chow
ef831268e0 fix(bitswap) handle error 
@whyrusleeping

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:19 +00:00
Brian Tiger Chow
77696a47f7 events(bitswap) try the new event logger in the bitswap GetBlock method 
@jbenet
@whyrusleeping

Let me know if you want to direct the eventlog output to _both_ the file
and stderr. Right now it goes to file. Perhaps this is just a minor bip
in the larger discussion around log levels.

https://github.com/jbenet/go-ipfs/issues/292

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:18 +00:00
Brian Tiger Chow
cfd7d5369b test(bitswap) 
@whyrusleeping This appears to be a timing issue. The asynchronous
nature of the new structure provides has the bitswap waiting on the
context a bit more. This isn't a problem at all, but in this test, it
makes the functions return in an inconveniently timely manner.

TODO don't let the test depend on time.

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-12-05 20:53:18 +00:00
Jeromy
5dece164cc dont panic on empty wantlist 2014-12-05 20:53:18 +00:00
Jeromy
5be35a83f1 beginnings of a bitswap refactor 2014-12-05 20:53:18 +00:00
Brian Tiger Chow
72a0cc18ce fix(bitswap) shutdown 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-11-25 06:12:36 -08:00
Brian Tiger Chow
3fdbd6cd15 fix(bitswap/notifications) don't force sender to block on receiver 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-11-25 06:12:35 -08:00
Brian Tiger Chow
ed4a8eb782 chore(tests) add Short() -> SkipNow() to slowest tests 
vanilla:
    21.57 real        45.14 user         8.51 sys

short:
    14.40 real        31.13 user         5.56 sys

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
 2014-11-15 02:10:53 -08:00
Brian Tiger Chow
3663eef5ac refctor(bitswap/network) replace Network interface with Dialer interface 2014-11-15 02:10:53 -08:00
Brian Tiger Chow
0b42d77e13 refactor(core, bitswap) split bitswap init into two steps 
@jbenet
 2014-11-15 02:10:53 -08:00
Brian Tiger Chow
154cf4af75 refactor(bitswap/network) rename -> BitSwapNetwork 
remove 'adapter' concept
instead, describe the component as the bitswap network

it's still an adapter, but it's just not necessary to describe it as
such
 2014-11-15 02:10:53 -08:00
Brian Tiger Chow
cf1d463885 rename var 2014-11-15 02:10:53 -08:00
Brian Tiger Chow
2bc82adfae style(bitswap) rename Adapter -> BitSwapNetwork for clarity 2014-11-15 02:10:52 -08:00
Brian Tiger Chow
919fb31a16 style(bitswap) rename variable to 'routing' 2014-11-15 02:10:52 -08:00
Jeromy
d4c819e97d log -> logf 2014-11-12 10:39:11 -08:00
Jeromy
be5d01b6a6 more doc comments 2014-11-08 22:44:37 -08:00
Brian Tiger Chow
34561b0da8 docs(exchange) 2014-11-08 21:42:37 -08:00
Juan Batiz-Benet
e5198b1446 bitswap error -> debug (use IPFS_LOGGING=debug) 2014-11-07 14:53:55 -08:00
Brian Tiger Chow
83716af890 fix(bitswap) shut down async 2014-11-05 10:13:24 -08:00
Brian Tiger Chow
40c5cca117 fix(bitswap) always cancel on return 2014-11-05 10:04:20 -08:00
Brian Tiger Chow
a529378ce0 fix(bitswap) don't 'go' local function calls 2014-11-05 10:04:20 -08:00
Brian Tiger Chow
23096de3c4 fix(net) pass contexts to dial peer 2014-11-05 10:04:20 -08:00
Brian Tiger Chow
c60d011764 fix(exchange) add context to DialPeer 2014-11-05 10:04:20 -08:00
Brian Tiger Chow
45b1929342 fix(bitswap_test) race cond 
https://github.com/jbenet/go-ipfs/issues/270#issuecomment-61826022
 2014-11-05 10:01:22 -08:00
Brian Tiger Chow
49ac059c37 docs: TODO 2014-11-02 20:40:25 -08:00
Jeromy
317ca2f865 benchmark secure channel 2014-11-01 16:07:56 -07:00
Brian Tiger Chow
42dfc50250 docs(bitswap/message) BitSwapMessage interface 2014-10-27 22:43:54 -07:00
Brian Tiger Chow
edf99f5e20 fix(bitswap) preserve ordering in bitswap message 2014-10-27 22:43:54 -07:00
Brian Tiger Chow
91a31a3e7d test(bitswap/message) no duplicates 2014-10-27 21:58:21 -07:00
Brian Tiger Chow
cebeff43b9 style(bitswap/message) rename method -> AddBlock 
to emphasize idempotence
 2014-10-27 21:58:21 -07:00
Brian Tiger Chow
caedb64697 fix(bitswap/message) impl with map to ensure no duplicate blocks 
comes at the cost of O(n) Blocks() method.
 2014-10-27 21:58:21 -07:00
Brian Tiger Chow
2c4fefb9d6 style(bitswap/message) rename struct 
so there's one less name to think about
 2014-10-27 21:58:20 -07:00
Brian Tiger Chow
f94d6a37b6 refactor(bitswap/message) use map to prevent duplicate entries 
A nice invariant for bitswap sessions:

        Senders and receivers can trust that messages do not contain
        duplicate blocks or duplicate keys. Backing the message with a
        map enforces this invariant.

        This comes at the cost of O(n) getters.
 2014-10-27 21:58:20 -07:00
Brian Tiger Chow
842b910853 style(bitswap/message) rename AppendWanted -> AddWanted 
implementation will be patched to ensure bitswap messages cannot contain
duplicate blocks or keys
 2014-10-27 21:58:20 -07:00
Brian Tiger Chow
8193049dda fix(bitswap) duplicate key in wantlist 
@whyrusleeping noticed this a couple days ago

potential long-term fix: prevent duplicate entries in the wantlist by
using a map/set and iterating over this data structure on export
 2014-10-27 21:58:20 -07:00
Jeromy
d92db12460 lots of logging 2014-10-26 00:45:40 +00:00
Jeromy
ab7491f809 logging, logging, and some minor logging 2014-10-25 14:50:22 -07:00
Jeromy
e1f2fe75f8 add in dag removal 2014-10-25 12:39:36 -07:00
Brian Tiger Chow
0dba976070 style(bitswap) import 2014-10-25 04:14:23 -07:00
Brian Tiger Chow
7f40a08b12 fix(bitswap) rm todo 2014-10-25 04:14:17 -07:00
Juan Batiz-Benet
184c25430b go-vet friendly codebase 
- distinguish log.Error and log.Errorf functions
- Initialize structs with field names
- A bit of unreachable code (defers)
 2014-10-25 03:46:39 -07:00
Brian Tiger Chow
c848202c7d fix(bitswap) move mutex up to strategy from ledger 
addresses concurrent access in bitswap session
 2014-10-24 16:17:15 -07:00
Brian Tiger Chow
715f5f4a19 fix(blockstore, bitswap) enforce threadsafety in blockstore 
fixes data race detected in a testnet test
 2014-10-24 16:16:41 -07:00
Brian Tiger Chow
80b573425b refactor(bitswap) mv proto PBMessage -> Message 2014-10-22 21:49:46 -07:00
Brian Tiger Chow
d3ac9ceee3 misc(exch/bitswap) add TODOs 2014-10-22 15:54:18 -07:00
Brian Tiger Chow
8823f46248 fix(exch/bs/pb) rename proto package -> bitswap_message_pb 2014-10-22 15:54:18 -07:00
Brian Tiger Chow
15605fb18f refactor(exchange/bitswap) move proto to internal pb package 2014-10-22 15:54:17 -07:00
Juan Batiz-Benet
f7c1ed39e0 renamed datastore.go -> go-datastore 2014-10-21 15:10:58 -07:00
Juan Batiz-Benet
9ca87fbb93 peer.Peer is now an interface 
![](http://m.memegen.com/77n7dk.jpg)
 2014-10-20 03:26:46 -07:00
Juan Batiz-Benet
c894b1d295 iiii -> peerToQuery 
(that wasn't mine :p)
 2014-10-18 04:28:24 -07:00
Juan Batiz-Benet
4b5906e466 logging + tweaks 2014-10-18 04:28:24 -07:00
Juan Batiz-Benet
a5a7d99860 meant to call net.DialPeer 2014-10-18 04:28:24 -07:00
Juan Batiz-Benet
1555ce7c48 bitswap dials peers 
Important bugfix. Otherwise bitswap cannot message peers
the node has not connected to yet :(
 2014-10-18 04:28:23 -07:00
Juan Batiz-Benet
338b037238 clean up and add inet.Network to bitswap 
new Service interface
 2014-10-10 20:43:04 -07:00
Juan Batiz-Benet
972c0f7b4b u.DOut -> log.Debug 
and other logging switches. I kept the u.PErr and u.POut in cli
commands, as those do need to write raw output directly.
 2014-10-09 04:50:22 -07:00
Juan Batiz-Benet
7c5679536c bugfix: use consistent interface 
We'll want a `type blocks.Block interface {}` later, but
for now, make sure Blockstore uses ptrs for both Get and Put.

+ fix NewBlock output compile error
 2014-10-07 21:32:17 -07:00
Jeromy
6e0cfb3273 removed error from return type of blocks.NewBlock() 2014-10-07 20:46:01 +00:00
Juan Batiz-Benet
77fccaa2f3 Obviated need for .ID.Pretty() all over the place. 2014-10-06 04:23:55 -07:00
Brian Tiger Chow
e2a9c5de00 feat(net:service, routing) remove error return value 2014-09-24 23:35:36 -04:00
Brian Tiger Chow
0e494690b3 feat(bitswap:network) propagate errors up the stack 
Rather than pushing errors back down to lower layers, propagate the
errors upward.

This commit adds a `ReceiveError` method to BitSwap's network receiver.

Still TODO: rm the error return value from:

    net.service.handler.HandleMessage

This is inspired by delegation patterns in found in the wild.
 2014-09-24 23:35:36 -04:00
Jeromy
c044d9c32e move mock routing tests to proper directory 2014-09-23 18:23:46 -04:00
Jeromy
414ff34194 change back to using Client method 2014-09-23 18:23:46 -04:00
Jeromy
c45cc8c448 implement a mock dht for use in testing 2014-09-23 18:23:46 -04:00
Brian Tiger Chow
b85d1554cc doc(bitswap:strat) add note to remove blocks from peer's wantlist after 
sending
 2014-09-22 04:06:19 -07:00
Brian Tiger Chow
9d7ae40003 feat(bitswap) expose ability to toggle "niceness" 
true -> always send to peer

false -> use ledger-based strategy described in IPFS paper draft 3
 2014-09-22 04:06:19 -07:00
Brian Tiger Chow
767d6ca633 refac(bitswap, util) extract KeySet 2014-09-22 04:06:19 -07:00
Brian Tiger Chow
faee10effe test(bitswap) send entire wantlist to peers 
fix(bitswap) pass go vet

fixes #97

https://github.com/jbenet/go-ipfs/issues/97
 2014-09-22 04:06:19 -07:00
Brian Tiger Chow
39ad222da9 fix(bitswap) keep interface the same 
changing the bitswap interace breaks tests and makes things a bit
difficult going forward. I think I have a temporary solution to replace
the async method.

this commit partially reverts changes from:

ec50703395098f75946f0bad01816cc54ab18a58

ec50703395
 2014-09-22 04:06:18 -07:00
Brian Tiger Chow
2179b5d77b fix(bitswap:testnet) Provide takes ctx 2014-09-22 04:06:18 -07:00
Brian Tiger Chow
b806270e5d test(bitswap) test sending wantlist to peers 2014-09-22 04:06:18 -07:00
Brian Tiger Chow
b4ef99bc81 fix(exch) name the error 2014-09-22 04:06:18 -07:00
Brian Tiger Chow
b5ea124a76 style(bitswap) swap argument order 2014-09-22 04:06:18 -07:00
Brian Tiger Chow
7d62be76ad chore(bitswap) cleanup 2014-09-22 04:06:18 -07:00
Brian Tiger Chow
60798b800a style(bitswap) make signature more readable 2014-09-22 04:06:18 -07:00
Juan Batiz-Benet
8112fae7b3 get bitswap working with dht 
@perfmode using non-async version as apparently there's
a bug in async. will look into it.
 2014-09-22 04:06:18 -07:00
Juan Batiz-Benet
52cefb16cd Routing uses context now 
@perfmode boom
 2014-09-22 04:06:18 -07:00
Brian Tiger Chow
315e121ef9 feat(bitswap:message) implement FromNet 2014-09-22 04:06:16 -07:00
Brian Tiger Chow
b7b046582b test(bitswap) test with swarm of ~500 instances 
test(bitswap) run synchronously to aid the scheduler
 2014-09-22 04:06:16 -07:00
Brian Tiger Chow
d0a5339547 feat(bitswap) ACTIVATE FULL CONCURRENCY cap'n 
fix(bitswap) Put synchronously. Then notify async
 2014-09-22 04:06:16 -07:00
Brian Tiger Chow
88f5be3f0d test(bitswap:testnet) shuffle the providers 
to avoid letting client rely on order for correctness
 2014-09-22 04:06:16 -07:00
Brian Tiger Chow
8213cfbaa4 docs(bitswap:strat) interface comments 2014-09-22 04:06:16 -07:00
Brian Tiger Chow
251f1d7f00 test(bitswap) add SessionGenerator 2014-09-22 04:06:16 -07:00
Brian Tiger Chow
5aa6ccbad5 refac(bitswap) nil slices are 'range'able 2014-09-22 04:06:16 -07:00
Brian Tiger Chow
331fcd1756 chore(bitswap) rm unused helper func 2014-09-22 04:06:16 -07:00
Brian Tiger Chow
a5fb64071a test(bitswap) enable get block test 2014-09-22 04:06:16 -07:00
Brian Tiger Chow
6e7a12dc11 refac(exch:offline) move offline exchange to its own package 2014-09-22 04:06:15 -07:00
Brian Tiger Chow
ddf889d876 test(bitswap) send block from one instance to another 2014-09-22 04:06:15 -07:00
Brian Tiger Chow
800af9ca3a fix(bitswap:message) don't use proto internally 2014-09-22 04:06:15 -07:00
Brian Tiger Chow
57e088bbff fix(bitswap:testnet) use peer.Map 2014-09-22 04:06:15 -07:00
Brian Tiger Chow
a8a7caa088 refac(bitswap:testnet) give testnet its own package 2014-09-22 04:06:15 -07:00
Brian Tiger Chow
9f685af14f test(bitswap) 2014-09-22 04:06:15 -07:00
Brian Tiger Chow
543dfeea35 refac(bitswap) less concurrency while testing and iterating 2014-09-22 04:06:15 -07:00
Brian Tiger Chow
6e1c3b36bb fix(bitswap) check for nil in public interface 2014-09-22 04:06:15 -07:00
Brian Tiger Chow
c80c8aa977 test(bitswap:testnet) 
misc:
* test network client getting more than max
* test for find providers
* rename factory method
* local network
* misc test improvements
* test bitswap get block timeout
* test provider exists but cannot connect to peer
* test sending a message async over local network
 2014-09-22 04:06:15 -07:00
Brian Tiger Chow
7975ffe721 fix(exchange) package name 2014-09-22 04:06:15 -07:00
Brian Tiger Chow
0c67019447 style(exch:bitswap) rename adapter, session, etc. 
style(exch:bitswap) rename NetMessage adapter impl
 2014-09-22 04:06:14 -07:00
Brian Tiger Chow
071a66495f style(exch:bitswap) rename variable 2014-09-22 04:06:14 -07:00
Brian Tiger Chow
71aed67413 feat(bitswap) broadcast block to routing, peers on receipt 2014-09-22 04:06:14 -07:00
Brian Tiger Chow
98a6e9fac2 feat(exch:bitswap) simply get method 2014-09-22 04:06:14 -07:00
Brian Tiger Chow
74e81e06fa refac(bitswap) extract const 2014-09-22 04:06:14 -07:00
Brian Tiger Chow
9a18fd6354 chore(exch, bitswap) misc trivial cleanup 2014-09-22 04:06:14 -07:00
Brian Tiger Chow
e907b2e03c feat(exchange) pass ctx to exchange.HasBlock(...) 2014-09-22 04:06:14 -07:00
Brian Tiger Chow
1054b8d8ad fix(bitswap) use passed ctx 2014-09-22 04:06:14 -07:00
Brian Tiger Chow
42770cc39a refac(exchange) replace timeout -> context in API 2014-09-22 04:06:14 -07:00
Brian Tiger Chow
252be07ec5 refac(bitswap) let adapter be created with nil delegate 
yay deleting code.
 2014-09-22 04:06:14 -07:00
Brian Tiger Chow
0bd8f2092b refac(routing) replace timeout -> ctx 
@jbenet oh hai there!
 2014-09-22 04:06:14 -07:00
Brian Tiger Chow
81da645ed6 chore(bitswap) remove unused const 2014-09-22 04:06:14 -07:00
Brian Tiger Chow
85f84fe446 refac(ex:bs) remove local peer ref until shown to be necessary 2014-09-22 04:06:13 -07:00
Brian Tiger Chow
d82a2517d1 refac(exch:bitswap) always notify strategy when message sent 2014-09-22 04:06:13 -07:00
Brian Tiger Chow
335b50f4c6 style(ex:bitswap) put public methods at top 2014-09-22 04:06:13 -07:00
Brian Tiger Chow
5cec6197ae test(exch:bs:strategy) test accounting consistency 
> Why expose num bytes sent and received?

    Makes it easy to test consistency of the ledgers

> Got a better reason?

    Makes it possible to expose metrics to the people-facing API
 2014-09-22 04:06:13 -07:00
Brian Tiger Chow
ded1f8f5a8 fix(bitswap) compiler errors 
didn't run tests after the refactor. apologies.
 2014-09-22 04:06:13 -07:00
Brian Tiger Chow
e1fe4f6d60 refac(exchange) rename exchange.Interface to match golang conventions 
examples:

    http://golang.org/pkg/container/heap/#Interface

    http://golang.org/pkg/net/#Interface

    http://golang.org/pkg/sort/#Interface
 2014-09-22 04:06:13 -07:00
Brian Tiger Chow
fd086b9c48 refac(exchange) bitswap -> exchange/bitswap 
Move go-ipfs/bitswap package to go-ipfs/exchange/bitswap

* Delineates the difference between the generic exchange interface and
  implementations (eg. BitSwap protocol)

  Thus, the bitswap protocol can be refined without having to overthink
  how future exchanges will work. Aspects common to BitSwap and other
  exchanges can be extracted out to the exchange package in piecemeal.

  Future exchange implementations can be placed in sibling packages next
  to exchange/bitswap. (eg. exchange/multilateral)
 2014-09-22 04:06:13 -07:00