Commit Graph

520 Commits

Author SHA1 Message Date
Jeromy Johnson
594ae64f15 Merge pull request #3129 from ipfs/feat/default-rename
commands: replace <default> keyword with <<default>>
2016-08-26 09:41:14 -07:00
Jakub Sztandera
7e5393c4db
commands: replace <default> keyword with <<default>>
This way if we use <default> in description (we use thigns like <hash>
already), it won't conflict and modify the description in unwanted way.

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2016-08-26 18:20:17 +02:00
Jeromy
05b197df2d update deps for libp2p 3.4.0
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
2016-08-25 19:02:55 -07:00
Jeromy
8a75a8cf08 commands: fix panic when stdin is empty for string args
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
2016-08-07 09:24:17 -07:00
Jeromy
068c6d2211 commands/cli: fix reading from stdin message
Only print "Reading from /dev/stdin" message when we actually read from
stdin (and not in other cases such as ipfs add --help).

License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
2016-08-03 09:04:41 -07:00
Jeromy Johnson
16c5a89dd4 Merge pull request #3023 from ipfs/feature/eval-symlink-windows
cli: do ToSlash after EvalSymlinks to remove platform specific slashes
2016-08-03 06:29:54 -07:00
Jeromy Johnson
8c77ff8188 Merge pull request #2983 from yuvallanger/sort-subcommands
Sort SUBCOMMANDS section of help output
2016-08-03 05:35:05 -07:00
Jakub Sztandera
40741eae19 cli: do ToSlash after EvalSymlinks to remove platform specific slashes
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2016-08-01 16:38:29 +01:00
Jeromy
ed551131f2 commands: fix panic when expected files field is nil
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
2016-07-25 09:12:58 -07:00
Yuval Langer
7470ae5428 Sort SUBCOMMANDS section of help output
License: MIT
Signed-off-by: Yuval Langer <yuval.langer@gmail.com>
2016-07-22 00:19:26 +03:00
Jeromy
9ff238e860 a little more cleanup
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
2016-07-09 13:12:04 -07:00
Jeromy
c1425346d0 remove badcode
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
2016-07-09 13:04:09 -07:00
Jeromy
b034a0d8e8 and special case that one thing because why not
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
2016-07-09 11:33:02 -07:00
Jeromy
cd46743717 cleanup
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
2016-07-08 16:04:42 -07:00
Jeromy
467eb8db00 docs
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
2016-07-08 15:49:34 -07:00
Jeromy
1aeda7eb6e ignore those last bits, this time its for real
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
2016-07-08 14:35:18 -07:00
Jeromy
a6af6c504b clean up previous work a bit
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
2016-07-08 11:09:12 -07:00
Jeromy
96433cc6e1 starting to rework stdin handling
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
2016-07-07 16:58:43 -07:00
Jakub Sztandera
b68e37f4c3 Resolve symlinks of testfiles
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2016-07-01 09:48:06 +02:00
Jakub Sztandera
fe7b01f14e Resolve symlink if it is directly referenced in cli (#2897)
* Resolve symlink if it is directly referenced in cli

test: Directly referenced symlink should be resolved

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>

* sharness: add test for symlink in the middle

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2016-06-28 12:06:50 -07:00
Jakub Sztandera
1c0f18dfed Add default true options handling
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2016-06-28 19:51:56 +02:00
Jakub Sztandera
f144a84247 Add default to recursive option
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2016-06-28 19:51:56 +02:00
Jakub Sztandera
d9d0446d45 Remove new line after synopsis section
As synopsis is only one line long it is overkill

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2016-06-28 19:51:56 +02:00
Jakub Sztandera
6cafb46584 Add Synopsis generator test
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2016-06-28 19:51:56 +02:00
Jakub Sztandera
206529730a Add Synopsis autogenerator
Generates synopsis automagically

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2016-06-28 19:51:56 +02:00
Thomas Gardner
059b726bb5 commands: update go-log dependency
License: MIT
Signed-off-by: Thomas Gardner <tmg@fastmail.com>
2016-06-26 12:36:25 +10:00
Thomas Gardner
2ad63fd0df commands: improve test coverage for FileArg parsing
License: MIT
Signed-off-by: Thomas Gardner <tmg@fastmail.com>
2016-06-26 12:28:55 +10:00
Thomas Gardner
ddc8d0c60c commands: remove EnableStdin support for StringArg
With verbose flag:
* remove EnableStdin() flags on all StringArg,

* remove all unneeded parsing code for StringArg, and print an
* informative message if `ipfs` begins reading from a CharDevice,

* remove broken go tests for EnableStdin cli parsing, and add some
* trivial test cases for reading FileArg from stdin,

* add a panic to prevent EnableStdin from being set on
* StringArg in the future.

Resolves: #2877, #2870
License: MIT
Signed-off-by: Thomas Gardner <tmg@fastmail.com>
2016-06-26 12:28:55 +10:00
Jakub Sztandera
ce8c8a7a71 Update go-log in whole dependency tree (#2898)
* Update golog in go-ipfs

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>

* Update go-libp2p for go-log

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>

* Update go-libp2p-secio for go-log

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>

* Update go-libp2p-crypto for go-log

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>

* Update go-libp2p-peer for go-log

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>

* Import peersore, it wasn't imported

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>

* Update peerstore

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>

* Update peer

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>

* Update secio

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>

* Update go-libp2p

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2016-06-24 09:38:07 -07:00
Jeromy
8e505f291f fix progress bar in add
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
2016-06-22 17:09:35 -07:00
Jeromy Johnson
0f3ae0736a Merge pull request #2853 from ipfs/feature/decapitalize-Debug
Decapitalized log.Debug messages
2016-06-17 10:26:20 -07:00
Jeromy Johnson
e5e2f2c19c Merge pull request #2822 from ipfs/feature/stdin-stable
Change logic of stdin input to be last and only if required
2016-06-15 11:32:42 -07:00
Richard Littauer
b6a3435bb5 Decapitalized log.Debug messages
According to golang standards, these should not be capitalized nor having a trailing period, AFAIK.

License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
2016-06-15 08:56:34 +01:00
Jakub Sztandera
a2cd3ebca0 Remove errors pointed out by govet
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2016-06-14 13:40:16 +02:00
Jakub Sztandera
da4e54c3db Change stdin handling to be only used if needed
or if user asks for it

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2016-06-13 13:09:52 +02:00
Jakub Sztandera
eaccd07505 Update go-log
https://github.com/ipfs/go-log/pull/3

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2016-06-09 23:37:09 +02:00
Jakub Sztandera
d7913c893a Migrate rs/cors to gx
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2016-05-31 22:40:41 +02:00
Jeromy Johnson
6c3350369e Merge pull request #2516 from Stebalien/protobuf-content-type
Correctly set the content type for `object get --encoding=protobuf`
2016-05-28 23:28:45 -07:00
Jakub Sztandera
70342314ae Allow to specify where to put default options in option desciption
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2016-05-19 18:54:37 +02:00
Dominic Della Valle
e2ccfdb8df Fix typo in files command error message
License: MIT
Signed-off-by: Dominic Della Valle <ddvpublic@gmail.com>
2016-05-17 03:49:22 -04:00
Jakub Sztandera
7f61b3170f Add logic for copying ShortDes to LongDesc if it is not present
This is the best place for inserting it that I found.

Test in #2648 should be modified to run `Root.ProcessHelp()`.

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2016-05-14 13:23:35 +02:00
Richard Littauer
4489021fff Show Synopsis in long help
I think that this is useful, even though it is also shown in the Arguments and Options section below. What do you think, @noffle?

License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
2016-05-12 14:09:16 -04:00
Hector Sanjuan
57b494a70c Update go-log to 1.1.0 and fix calls to go-log.Uuid
License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>
2016-05-04 23:17:21 +02:00
Stephen Whitmore
0a45ada4ed CLI: discoverability and consistency (#2542)
* reduces help indent from 4 to 2 spaces

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* reduces horz/vert space taken by "ipfs" cmd

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* show subcommands on shorthelp

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Drops colons at the end of cmd headings.

This makes command headings consistent with the output of 'ipfs', which
does not include colons.

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* more consistent output between short-/long-help

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Puts DESCRIPTION before SUBCOMMANDS.

Users likely want to understand what a command does before worrying
about its subcommands.

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Keeps ipfs cmd from outputting its subcmds twice.

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Removes redundant synopsis from "file"

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Removes extra whitespace from longhelp

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Consistent spacing whether SUBCMDS or not.

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Removes redundant SUBCMD output from ipfs object.

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Removes redundant synopsis from "name"

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Newline after Description only if it exists.

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Removes redundant synopsis from "bootstrap"

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Removes redundant synopsis from "swarm"

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Removes trailing newline in ping help.

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Prints shorthelp on parse error.

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* tiny comment fixes

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* updates README usage

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Don't include extra whitespace if no .MoreHelp

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* description improvements

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Hides the obscure 'file' subcommand.

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Splits 'ipfs daemon' into Short and Long help.

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Removes redundant synopsis from "config"

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Wraps lines to keep from going over 80.

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* specify repo separately

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* s/structure/hierarchy

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* missing .

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Removes trailing colon from 'usage' test.

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Updates sharness test error messages.

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Removes trailing colon from 'usage' test.

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Updates add-symlink to use /bin/sh.

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Removes "hierarchy".

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

* Updates "ipfs ping" synopsis.

* Updates t0040 with latest wording.

* Removes unnecessary daemon setup.

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>
2016-04-28 14:08:32 -07:00
Dominic Della Valle
af6e7ad9ea Fix dot path parsing on Windows
License: MIT
Signed-off-by: Dominic Della Valle <ddvpublic@gmail.com>
2016-04-28 15:03:41 -04:00
Thomas Gardner
7279153a0c commands/cli: Add a test for 3e8244
License: MIT
Signed-off-by: Thomas Gardner <tmg@fastmail.com>
2016-04-16 12:22:17 +10:00
Thomas Gardner
3e824412d9 commands/cli: fix parsing of incorrect permutations
parseOpts now does some preliminary path screening to prevent
command sequences like

	`ipfs <hash> cat`

from succeeding. The tests affected by this have been slightly altered,
but should be restored once parseOpts is decoupled from path analysis.

Command suggestion printing has also been factored into a single
function.

Fixes: #2501
License: MIT
Signed-off-by: Thomas Gardner <tmg@fastmail.com>
2016-04-05 21:53:21 +10:00
Steven Allen
a72d26b875 api: correctly set the content type for object get --encoding=protobuf
It used to default to `application/json` but is now correctly set to
`application/protobuf`.

fixes #2469

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
2016-03-31 17:14:41 -04:00
Jeromy Johnson
850602361d fix double transfer encoding head problem
License: MIT
Signed-off-by: Jeromy Johnson <why@ipfs.io>
2016-03-14 16:26:49 -07:00
Jeromy
767ee13ea2 add default option value support to commands lib
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
2016-03-04 10:58:27 -08:00