From fb58b0ae85f43c938c50a55aa1f88d72c41c6eb3 Mon Sep 17 00:00:00 2001
From: Hector Sanjuan <code@hector.link>
Date: Tue, 26 Nov 2024 19:19:07 +0100
Subject: [PATCH] tests/cli: fix flapping tests (#10600)

The issue is that for dht providing to work correctly, at least two nodes must
have dht routing.

Before, dht providing in the test always failed, but the test succeeded when
the tested-CID was the one that the failure happened with (the first in the
list for ProvideMany).
---
 test/cli/delegated_routing_v1_http_proxy_test.go | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/test/cli/delegated_routing_v1_http_proxy_test.go b/test/cli/delegated_routing_v1_http_proxy_test.go
index 79fd726a4..ef3bc4fe2 100644
--- a/test/cli/delegated_routing_v1_http_proxy_test.go
+++ b/test/cli/delegated_routing_v1_http_proxy_test.go
@@ -15,9 +15,11 @@ func TestRoutingV1Proxy(t *testing.T) {
 	t.Parallel()
 
 	setupNodes := func(t *testing.T) harness.Nodes {
-		nodes := harness.NewT(t).NewNodes(2).Init()
+		nodes := harness.NewT(t).NewNodes(3).Init()
 
-		// Node 0 uses DHT and exposes the Routing API.
+		// Node 0 uses DHT and exposes the Routing API.  For the DHT
+		// to actually work there will need to be another DHT-enabled
+		// node.
 		nodes[0].UpdateConfig(func(cfg *config.Config) {
 			cfg.Gateway.ExposeRoutingAPI = config.True
 			cfg.Discovery.MDNS.Enabled = false
@@ -49,6 +51,15 @@ func TestRoutingV1Proxy(t *testing.T) {
 		})
 		nodes[1].StartDaemon()
 
+		// This is the second DHT node. Only used so that the DHT is
+		// operative.
+		nodes[2].UpdateConfig(func(cfg *config.Config) {
+			cfg.Gateway.ExposeRoutingAPI = config.True
+			cfg.Discovery.MDNS.Enabled = false
+			cfg.Routing.Type = config.NewOptionalString("dht")
+		})
+		nodes[2].StartDaemon()
+
 		// Connect them.
 		nodes.Connect()