From e66e8bbe964c7b0eb6feb592023bfcd0898fabd1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Magiera?= Date: Thu, 1 Jun 2017 20:11:46 +0200 Subject: [PATCH] Corenet API: Review fixes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit License: MIT Signed-off-by: Ɓukasz Magiera --- core/commands/corenet.go | 17 +++++++---------- core/commands/root.go | 2 +- 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/core/commands/corenet.go b/core/commands/corenet.go index 736e4ad72..e33c27369 100644 --- a/core/commands/corenet.go +++ b/core/commands/corenet.go @@ -465,7 +465,7 @@ var corenetCloseCmd = &cmds.Command{ useHandlerID := false if !closeAll && len(req.Arguments()) == 0 { - res.SetError(errors.New(" handlerID nor stream protocol"), cmds.ErrNormal) + res.SetError(errors.New("no handlerID nor stream protocol specified"), cmds.ErrNormal) return } else if !closeAll { @@ -479,11 +479,11 @@ var corenetCloseCmd = &cmds.Command{ } if closeAll || useHandlerID { - for _, s := range n.Corenet.Streams.Streams { - if !closeAll && handlerID != s.HandlerID { + for _, stream := range n.Corenet.Streams.Streams { + if !closeAll && handlerID != stream.HandlerID { continue } - s.Close() + stream.Close() if !closeAll { break } @@ -491,19 +491,16 @@ var corenetCloseCmd = &cmds.Command{ } if closeAll || !useHandlerID { - for _, a := range n.Corenet.Apps.Apps { - if !closeAll && a.Protocol != proto { + for _, app := range n.Corenet.Apps.Apps { + if !closeAll && app.Protocol != proto { continue } - a.Close() + app.Close() if !closeAll { break } } } - - if len(req.Arguments()) != 1 { - } }, } diff --git a/core/commands/root.go b/core/commands/root.go index 45dcb1112..f89079ba0 100644 --- a/core/commands/root.go +++ b/core/commands/root.go @@ -47,7 +47,7 @@ ADVANCED COMMANDS pin Pin objects to local storage repo Manipulate the IPFS repository stats Various operational stats - exp Experimental commands + corenet Libp2p stream mounting filestore Manage the filestore (experimental) NETWORK COMMANDS