coosld/kubo
1
0
Fork 0
mirror of https://github.com/ipfs/kubo.git synced 2026-03-09 18:28:08 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

chore: use assert.NoError instead of assert.Nil for errors

Browse Source
This commit is contained in:
Jorropo 2023-05-16 15:33:27 +02:00
parent 65b8d530b0
commit da28fbc65a
3 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/cli/gateway_range_test.go
View File

@ -31,10 +31,10 @@ func TestGatewayHAMTDirectory(t *testing.T) {
// Import fixtures
r, err := os.Open("./fixtures/TestGatewayHAMTDirectory.car")
assert.Nil(t, err)
assert.NoError(t, err)
defer r.Close()
err = node.IPFSDagImport(r, fixtureCid)
assert.Nil(t, err)
assert.NoError(t, err)
// Fetch HAMT directory succeeds with minimal refs
resp := client.Get(fmt.Sprintf("/ipfs/%s/", hamtCid))
@ -60,10 +60,10 @@ func TestGatewayMultiRange(t *testing.T) {
// Import fixtures
r, err := os.Open("./fixtures/TestGatewayMultiRange.car")
assert.Nil(t, err)
assert.NoError(t, err)
defer r.Close()
err = node.IPFSDagImport(r, fixtureCid)
assert.Nil(t, err)
assert.NoError(t, err)
// Succeeds fetching a range of blocks we have
resp := client.Get(fmt.Sprintf("/ipfs/%s", fileCid), func(r *http.Request) {

4
test/cli/gateway_test.go
View File

@ -28,7 +28,7 @@ func TestGateway(t *testing.T) {
cid := node.IPFSAddStr("Hello Worlds!")
peerID, err := peer.ToCid(node.PeerID()).StringOfBase(multibase.Base36)
assert.Nil(t, err)
assert.NoError(t, err)
client := node.GatewayClient()
client.TemplateData = map[string]string{
@ -480,7 +480,7 @@ func TestGateway(t *testing.T) {
})
node2PeerID, err := peer.ToCid(node2.PeerID()).StringOfBase(multibase.Base36)
assert.Nil(t, err)
assert.NoError(t, err)
nodes.StartDaemons().Connect()

8
test/cli/swarm_test.go
View File

@ -35,7 +35,7 @@ func TestSwarm(t *testing.T) {
res := node.RunIPFS("swarm", "peers", "--enc=json", "--identify")
var output expectedOutputType
err := json.Unmarshal(res.Stdout.Bytes(), &output)
assert.Nil(t, err)
assert.NoError(t, err)
assert.Equal(t, 0, len(output.Peers))
})
@ -48,7 +48,7 @@ func TestSwarm(t *testing.T) {
res := node.RunIPFS("swarm", "peers", "--enc=json", "--identify")
var output expectedOutputType
err := json.Unmarshal(res.Stdout.Bytes(), &output)
assert.Nil(t, err)
assert.NoError(t, err)
actualID := output.Peers[0].Identify.ID
actualPublicKey := output.Peers[0].Identify.PublicKey
actualAgentVersion := output.Peers[0].Identify.AgentVersion
@ -78,12 +78,12 @@ func TestSwarm(t *testing.T) {
otherNodeIDResponse := otherNode.RunIPFS("id", "--enc=json")
var otherNodeIDOutput identifyType
err := json.Unmarshal(otherNodeIDResponse.Stdout.Bytes(), &otherNodeIDOutput)
assert.Nil(t, err)
assert.NoError(t, err)
res := node.RunIPFS("swarm", "peers", "--enc=json", "--identify")
var output expectedOutputType
err = json.Unmarshal(res.Stdout.Bytes(), &output)
assert.Nil(t, err)
assert.NoError(t, err)
outputIdentify := output.Peers[0].Identify
assert.Equal(t, outputIdentify.ID, otherNodeIDOutput.ID)