From bd5be7efc8f76d3f1bfe2496c84944d019e25006 Mon Sep 17 00:00:00 2001 From: Overbool Date: Sat, 27 Oct 2018 22:52:24 +0800 Subject: [PATCH] commands/refs: drop goroutine License: MIT Signed-off-by: Overbool --- core/commands/refs.go | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/core/commands/refs.go b/core/commands/refs.go index 928f74fbc..5a85bed1f 100644 --- a/core/commands/refs.go +++ b/core/commands/refs.go @@ -168,21 +168,14 @@ Displays the hashes of all local objects. return err } - out := make(chan interface{}) - - go func() { - defer close(out) - - for k := range allKeys { - select { - case out <- &RefWrapper{Ref: k.String()}: - case <-req.Context.Done(): - return - } + for k := range allKeys { + err := res.Emit(&RefWrapper{Ref: k.String()}) + if err != nil { + return err } - }() + } - return res.Emit(out) + return nil }, Encoders: cmds.EncoderMap{ cmds.Text: cmds.MakeTypedEncoder(func(req *cmds.Request, w io.Writer, out *RefWrapper) error {