From b699e71c0b4c416f35f9782f5fb444341ae5e19e Mon Sep 17 00:00:00 2001 From: Jakub Sztandera Date: Sun, 21 Aug 2016 00:52:02 +0200 Subject: [PATCH] test: add invialid protobuf data testcase to dagreader License: MIT Signed-off-by: Jakub Sztandera --- unixfs/io/dagreader.go | 2 +- unixfs/io/dagreader_test.go | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/unixfs/io/dagreader.go b/unixfs/io/dagreader.go index 3b9dfcb28..53916aa57 100644 --- a/unixfs/io/dagreader.go +++ b/unixfs/io/dagreader.go @@ -131,7 +131,7 @@ func (dr *DagReader) precalcNextBuf(ctx context.Context) error { dr.buf = NewRSNCFromBytes(pb.GetData()) return nil case ftpb.Data_Metadata: - return errors.New("Shouldnt have had metadata object inside file") + return errors.New("shouldnt have had metadata object inside file") case ftpb.Data_Symlink: return errors.New("shouldnt have had symlink inside file") default: diff --git a/unixfs/io/dagreader_test.go b/unixfs/io/dagreader_test.go index 7924683cc..1321da4a6 100644 --- a/unixfs/io/dagreader_test.go +++ b/unixfs/io/dagreader_test.go @@ -144,6 +144,19 @@ func TestTypeFailures(t *testing.T) { } } +func TestBadPBData(t *testing.T) { + dserv := testu.GetDAGServ() + ctx, closer := context.WithCancel(context.Background()) + defer closer() + + node := mdag.NodeWithData([]byte{42}) + _, err := NewDagReader(ctx, node, dserv) + if err == nil { + t.Fatal("excepted error, got nil") + } + +} + func readByte(t testing.TB, reader *DagReader) byte { out := make([]byte, 1) c, err := reader.Read(out)