coosld/kubo
1
0
Fork 0
mirror of https://github.com/ipfs/kubo.git synced 2026-03-10 02:40:11 +08:00
Code Issues Actions 13 Packages Projects Releases Wiki Activity

refactor: remove redundant urlescape

Browse Source 
URL.Query() will already decode the query parameters
This commit is contained in:
Marcin Rataj 2020-12-12 12:28:42 +01:00
parent 3de5b14e0c
commit abb25a1cfc
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
core/corehttp/gateway_handler.go
View File

@ -186,13 +186,7 @@ func (i *gatewayHandler) getOrHeadHandler(w http.ResponseWriter, r *http.Request
// https://developer.mozilla.org/en-US/docs/Web/API/Navigator/registerProtocolHandler
// TLDR: redirect /ipfs/?uri=ipfs%3A%2F%2Fcid%3Fquery%3Dval to /ipfs/cid?query=val
if uriParam := r.URL.Query().Get("uri"); uriParam != "" {
// Browsers will pass URI in URL-escaped form, we need to unescape it first
uri, err := url.QueryUnescape(uriParam)
if err != nil {
webError(w, "failed to unescape uri query parameter", err, http.StatusBadRequest)
return
}
u, err := url.Parse(uri)
u, err := url.Parse(uriParam)
if err != nil {
webError(w, "failed to parse uri query parameter", err, http.StatusBadRequest)
return