From 886d47561a014aa3ee275207069404ad9e954362 Mon Sep 17 00:00:00 2001 From: Juan Batiz-Benet Date: Fri, 24 Jul 2015 14:41:54 -0700 Subject: [PATCH] http/client: log errors when stream copy fails License: MIT Signed-off-by: Juan Batiz-Benet --- commands/http/handler.go | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/commands/http/handler.go b/commands/http/handler.go index 3e7de8e7a..2b82b9a77 100644 --- a/commands/http/handler.go +++ b/commands/http/handler.go @@ -166,19 +166,14 @@ func (i internalHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) { streamChans, _, _ := req.Option("stream-channels").Bool() if isChan && streamChans { - // w.WriteString(transferEncodingHeader + ": chunked\r\n") - // w.Header().Set(channelHeader, "1") - // w.WriteHeader(200) - err = copyChunks(applicationJson, w, out) - if err != nil { - log.Debug("copy chunks error: ", err) + if err := copyChunks(applicationJson, w, out); err != nil { + log.Error("error while writing stream", err) } return } - err = flushCopy(w, out) - if err != nil { - log.Debug("Flush copy returned an error: ", err) + if err := flushCopy(w, out); err != nil { + log.Error("error while writing stream", err) } }