diff --git a/.github/workflows/test-migrations.yml b/.github/workflows/test-migrations.yml
new file mode 100644
index 000000000..1def94ff7
--- /dev/null
+++ b/.github/workflows/test-migrations.yml
@@ -0,0 +1,85 @@
+name: Migrations
+
+on:
+ workflow_dispatch:
+ pull_request:
+ paths:
+ # Migration implementation files
+ - 'repo/fsrepo/migrations/**'
+ - 'test/cli/migrations/**'
+ # Config and repo handling
+ - 'repo/fsrepo/**'
+ # This workflow file itself
+ - '.github/workflows/test-migrations.yml'
+ push:
+ branches:
+ - 'master'
+ - 'release-*'
+ paths:
+ - 'repo/fsrepo/migrations/**'
+ - 'test/cli/migrations/**'
+ - 'repo/fsrepo/**'
+ - '.github/workflows/test-migrations.yml'
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.event_name == 'push' && github.sha || github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ test:
+ strategy:
+ fail-fast: false
+ matrix:
+ os: [ubuntu-latest, windows-latest, macos-latest]
+ runs-on: ${{ matrix.os }}
+ timeout-minutes: 20
+ env:
+ TEST_VERBOSE: 1
+ IPFS_CHECK_RCMGR_DEFAULTS: 1
+ defaults:
+ run:
+ shell: bash
+ steps:
+ - name: Check out Kubo
+ uses: actions/checkout@v5
+
+ - name: Set up Go
+ uses: actions/setup-go@v6
+ with:
+ go-version-file: 'go.mod'
+
+ - name: Build kubo binary
+ run: |
+ make build
+ echo "Built ipfs binary at $(pwd)/cmd/ipfs/"
+
+ - name: Add kubo to PATH
+ run: |
+ echo "$(pwd)/cmd/ipfs" >> $GITHUB_PATH
+
+ - name: Verify ipfs in PATH
+ run: |
+ which ipfs || echo "ipfs not in PATH"
+ ipfs version || echo "Failed to run ipfs version"
+
+ - name: Run migration unit tests
+ run: |
+ go test ./repo/fsrepo/migrations/...
+
+ - name: Run CLI migration tests
+ env:
+ IPFS_PATH: ${{ runner.temp }}/ipfs-test
+ run: |
+ export PATH="${{ github.workspace }}/cmd/ipfs:$PATH"
+ which ipfs || echo "ipfs not found in PATH"
+ ipfs version || echo "Failed to run ipfs version"
+ go test ./test/cli/migrations/...
+
+ - name: Upload test results
+ if: always()
+ uses: actions/upload-artifact@v4
+ with:
+ name: ${{ matrix.os }}-test-results
+ path: |
+ test/**/*.log
+ ${{ runner.temp }}/ipfs-test/
diff --git a/bin/check_go_version b/bin/check_go_version
deleted file mode 100755
index 74320010b..000000000
--- a/bin/check_go_version
+++ /dev/null
@@ -1,44 +0,0 @@
-#!/bin/sh
-#
-# Check that the go version is at least equal to a minimum version
-# number.
-#
-# Call it for example like this:
-#
-# $ check_go_version "1.5.2"
-#
-
-USAGE="$0 GO_MIN_VERSION"
-
-die() {
- printf >&2 "fatal: %s\n" "$@"
- exit 1
-}
-
-# Get arguments
-
-test "$#" -eq "1" || die "This program must be passed exactly 1 arguments" "Usage: $USAGE"
-
-GO_MIN_VERSION="$1"
-
-UPGRADE_MSG="Please take a look at https://golang.org/doc/install to install or upgrade go."
-
-# Get path to the directory containing this file
-# If $0 has no slashes, uses "./"
-PREFIX=$(expr "$0" : "\(.*\/\)") || PREFIX='./'
-# Include the 'check_at_least_version' function
-. ${PREFIX}check_version
-
-# Check that the go binary exists and is in the path
-
-GOCC=${GOCC="go"}
-
-type ${GOCC} >/dev/null 2>&1 || die_upgrade "go is not installed or not in the PATH!"
-
-# Check the go binary version
-
-VERS_STR=$(${GOCC} version 2>&1) || die "'go version' failed with output: $VERS_STR"
-
-GO_CUR_VERSION=$(expr "$VERS_STR" : ".*go version.* go\([^[:space:]]*\) .*") || die "Invalid 'go version' output: $VERS_STR"
-
-check_at_least_version "$GO_MIN_VERSION" "$GO_CUR_VERSION" "${GOCC}"
diff --git a/bin/check_version b/bin/check_version
deleted file mode 100755
index 25007002c..000000000
--- a/bin/check_version
+++ /dev/null
@@ -1,77 +0,0 @@
-#!/bin/sh
-
-if test "x$UPGRADE_MSG" = "x"; then
- printf >&2 "fatal: Please set '"'$UPGRADE_MSG'"' before sourcing this script\n"
- exit 1
-fi
-
-die_upgrade() {
- printf >&2 "fatal: %s\n" "$@"
- printf >&2 "=> %s\n" "$UPGRADE_MSG"
- exit 1
-}
-
-major_number() {
- vers="$1"
-
- # Hack around 'expr' exiting with code 1 when it outputs 0
- case "$vers" in
- 0) echo "0" ;;
- 0.*) echo "0" ;;
- *) expr "$vers" : "\([^.]*\).*" || return 1
- esac
-}
-
-check_at_least_version() {
- MIN_VERS="$1"
- CUR_VERS="$2"
- PROG_NAME="$3"
-
- # Get major, minor and fix numbers for each version
- MIN_MAJ=$(major_number "$MIN_VERS") || die "No major version number in '$MIN_VERS' for '$PROG_NAME'"
- CUR_MAJ=$(major_number "$CUR_VERS") || die "No major version number in '$CUR_VERS' for '$PROG_NAME'"
-
- # We expect a version to be of form X.X.X
- # if the second dot doesn't match, we consider it a prerelease
-
- if MIN_MIN=$(expr "$MIN_VERS" : "[^.]*\.\([0-9][0-9]*\)"); then
- # this captured digit is necessary, since expr returns code 1 if the output is empty
- if expr "$MIN_VERS" : "[^.]*\.[0-9]*\([0-9]\.\|[0-9]\$\)" >/dev/null; then
- MIN_PRERELEASE="0"
- else
- MIN_PRERELEASE="1"
- fi
- MIN_FIX=$(expr "$MIN_VERS" : "[^.]*\.[0-9][0-9]*[^0-9][^0-9]*\([0-9][0-9]*\)") || MIN_FIX="0"
- else
- MIN_MIN="0"
- MIN_PRERELEASE="0"
- MIN_FIX="0"
- fi
- if CUR_MIN=$(expr "$CUR_VERS" : "[^.]*\.\([0-9][0-9]*\)"); then
- # this captured digit is necessary, since expr returns code 1 if the output is empty
- if expr "$CUR_VERS" : "[^.]*\.[0-9]*\([0-9]\.\|[0-9]\$\)" >/dev/null; then
- CUR_PRERELEASE="0"
- else
- CUR_PRERELEASE="1"
- fi
- CUR_FIX=$(expr "$CUR_VERS" : "[^.]*\.[0-9][0-9]*[^0-9][^0-9]*\([0-9][0-9]*\)") || CUR_FIX="0"
- else
- CUR_MIN="0"
- CUR_PRERELEASE="0"
- CUR_FIX="0"
- fi
-
- # Compare versions
- VERS_LEAST="$PROG_NAME version '$CUR_VERS' should be at least '$MIN_VERS'"
- test "$CUR_MAJ" -lt "$MIN_MAJ" && die_upgrade "$VERS_LEAST"
- test "$CUR_MAJ" -gt "$MIN_MAJ" || {
- test "$CUR_MIN" -lt "$MIN_MIN" && die_upgrade "$VERS_LEAST"
- test "$CUR_MIN" -gt "$MIN_MIN" || {
- test "$CUR_PRERELEASE" -gt "$MIN_PRERELEASE" && die_upgrade "$VERS_LEAST"
- test "$CUR_PRERELEASE" -lt "$MIN_PRERELEASE" || {
- test "$CUR_FIX" -lt "$MIN_FIX" && die_upgrade "$VERS_LEAST"
- true
- }
- }
- }
-}
diff --git a/cmd/ipfs/kubo/daemon.go b/cmd/ipfs/kubo/daemon.go
index 7daa66ee7..fa89bf632 100644
--- a/cmd/ipfs/kubo/daemon.go
+++ b/cmd/ipfs/kubo/daemon.go
@@ -334,7 +334,8 @@ func daemonFunc(req *cmds.Request, re cmds.ResponseEmitter, env cmds.Environment
}
// Use hybrid migration strategy that intelligently combines external and embedded migrations
- err = migrations.RunHybridMigrations(cctx.Context(), version.RepoVersion, cctx.ConfigRoot, false)
+ // Use req.Context instead of cctx.Context() to avoid attempting repo open before migrations complete
+ err = migrations.RunHybridMigrations(req.Context, version.RepoVersion, cctx.ConfigRoot, false)
if err != nil {
fmt.Println("Repository migration failed:")
fmt.Printf(" %s\n", err)
@@ -387,7 +388,8 @@ func daemonFunc(req *cmds.Request, re cmds.ResponseEmitter, env cmds.Environment
log.Errorf("failed to create autoconf client: %v", err)
} else {
// Start primes cache and starts background updater
- if _, err := client.Start(cctx.Context()); err != nil {
+ // Use req.Context for background updater lifecycle (node doesn't exist yet)
+ if _, err := client.Start(req.Context); err != nil {
log.Errorf("failed to start autoconf updater: %v", err)
}
}
diff --git a/core/commands/repo.go b/core/commands/repo.go
index 017143127..622e92d7e 100644
--- a/core/commands/repo.go
+++ b/core/commands/repo.go
@@ -423,19 +423,12 @@ migration. Versions below 16 require external migration tools.
return fmt.Errorf("downgrade from version %d to %d requires --allow-downgrade flag", currentVersion, targetVersion)
}
- // Check if repo is locked by daemon before running migration
- locked, err := fsrepo.LockedByOtherProcess(cctx.ConfigRoot)
- if err != nil {
- return fmt.Errorf("could not check repo lock: %w", err)
- }
- if locked {
- return fmt.Errorf("cannot run migration while daemon is running (repo.lock exists)")
- }
-
fmt.Printf("Migrating repository from version %d to %d...\n", currentVersion, targetVersion)
// Use hybrid migration strategy that intelligently combines external and embedded migrations
- err = migrations.RunHybridMigrations(cctx.Context(), targetVersion, cctx.ConfigRoot, allowDowngrade)
+ // Use req.Context instead of cctx.Context() to avoid opening the repo before migrations run,
+ // which would acquire the lock that migrations need
+ err = migrations.RunHybridMigrations(req.Context, targetVersion, cctx.ConfigRoot, allowDowngrade)
if err != nil {
fmt.Println("Repository migration failed:")
fmt.Printf(" %s\n", err)
diff --git a/docs/changelogs/v0.38.md b/docs/changelogs/v0.38.md
index 2edb31adf..2bffa5885 100644
--- a/docs/changelogs/v0.38.md
+++ b/docs/changelogs/v0.38.md
@@ -5,6 +5,7 @@
This release was brought to you by the [Shipyard](https://ipshipyard.com/) team.
- [v0.38.0](#v0380)
+- [v0.38.1](#v0381)
## v0.38.0
@@ -290,3 +291,34 @@ The new [`Internal.MFSNoFlushLimit`](https://github.com/ipfs/kubo/blob/master/do
| Jakub Sztandera | 1 | +67/-15 | 3 |
| Masih H. Derkani | 1 | +1/-2 | 2 |
| Dominic Della Valle | 1 | +2/-1 | 1 |
+
+## v0.38.1
+
+Fixes migration panic on Windows when upgrading from v0.37 to v0.38 ("panic: error can't be dealt with transactionally: Access is denied").
+
+Updates go-ds-pebble to v0.5.3 (pebble v2.1.0).
+
+### ๐ Changelog
+
+Full Changelog
+
+- github.com/ipfs/kubo:
+ - chore: v0.38.1
+ - fix: migrations for Windows (#11010) ([ipfs/kubo#11010](https://github.com/ipfs/kubo/pull/11010))
+ - Upgrade go-ds-pebble to v0.5.3 (#11011) ([ipfs/kubo#11011](https://github.com/ipfs/kubo/pull/11011))
+ - upgrade go-ds-pebble to v0.5.2 (#11000) ([ipfs/kubo#11000](https://github.com/ipfs/kubo/pull/11000))
+- github.com/ipfs/go-ds-pebble (v0.5.1 -> v0.5.3):
+ - new version (#62) ([ipfs/go-ds-pebble#62](https://github.com/ipfs/go-ds-pebble/pull/62))
+ - fix panic when batch is reused after commit (#61) ([ipfs/go-ds-pebble#61](https://github.com/ipfs/go-ds-pebble/pull/61))
+ - new version (#60) ([ipfs/go-ds-pebble#60](https://github.com/ipfs/go-ds-pebble/pull/60))
+ - Upgrade to pebble v2.1.0 (#59) ([ipfs/go-ds-pebble#59](https://github.com/ipfs/go-ds-pebble/pull/59))
+ - update readme (#57) ([ipfs/go-ds-pebble#57](https://github.com/ipfs/go-ds-pebble/pull/57))
+
+