From 5ce2deb5fc418abdd42bec61b8619b733589450f Mon Sep 17 00:00:00 2001 From: Christopher Buesser Date: Thu, 2 May 2019 19:43:46 -0400 Subject: [PATCH] Test Fix: Nil error handling In TestExternalUnmount, the Mount function is called which returns an error which can be nil. The error type is then used in a comparison where Error() is called on it. If the error is nil, this results in a panic. Added a if err != nil {} guard to make sure that Error() is not called if the value is nil On branch go-test-fix Changes to be committed: modified: fuse/node/mount_test.go License: MIT Signed-off-by: Chris Buesser --- fuse/node/mount_test.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fuse/node/mount_test.go b/fuse/node/mount_test.go index 6cd2cf299..9c8783901 100644 --- a/fuse/node/mount_test.go +++ b/fuse/node/mount_test.go @@ -64,9 +64,12 @@ func TestExternalUnmount(t *testing.T) { mkdir(t, ipnsDir) err = Mount(node, ipfsDir, ipnsDir) - if strings.Contains(err.Error(), "unable to check fuse version") || err == fuse.ErrOSXFUSENotFound { - t.Skip(err) + if err != nil { + if strings.Contains(err.Error(), "unable to check fuse version") || err == fuse.ErrOSXFUSENotFound { + t.Skip(err) + } } + if err != nil { t.Fatalf("error mounting: %v", err) }