Merge pull request #8931 from ipfs/ci/add-more-checks

ci: add more golang strictness checks

.github/workflows/golang-analysis.yml

@@ -0,0 +1,37 @@
+on: [push, pull_request]
+name: Go Checks
+
+jobs:
+  unit:
+    runs-on: ubuntu-latest
+    name: All
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodules: recursive
+      - uses: actions/setup-go@v2
+        with:
+          go-version: "1.17.x"
+      - name: Check that go.mod is tidy
+        uses: protocol/multiple-go-modules@v1.2
+        with:
+          run: |
+            go mod tidy
+            if [[ -n $(git ls-files --other --exclude-standard --directory -- go.sum) ]]; then
+              echo "go.sum was added by go mod tidy"
+              exit 1
+            fi
+            git diff --exit-code -- go.sum go.mod
+      - name: gofmt
+        if: always() # run this step even if the previous one failed
+        run: |
+          out=$(gofmt -s -l .)
+          if [[ -n "$out" ]]; then
+            echo $out | awk '{print "::error file=" $0 ",line=0,col=0::File is not gofmt-ed."}'
+            exit 1
+          fi
+      - name: go vet
+        if: always() # run this step even if the previous one failed
+        uses: protocol/multiple-go-modules@v1.2
+        with:
+          run: go vet ./...

cmd/ipfs/daemon_linux.go

@@ -1,3 +1,4 @@
+//go:build linux
 // +build linux
 
 package main

cmd/ipfs/daemon_other.go

@@ -1,3 +1,4 @@
+//go:build !linux
 // +build !linux
 
 package main

cmd/ipfs/runmain_test.go

@@ -1,3 +1,4 @@
+//go:build testrunmain
 // +build testrunmain
 
 package main

cmd/ipfs/util/signal.go

@@ -1,3 +1,4 @@
+//go:build !wasm
 // +build !wasm
 
 package util

cmd/ipfs/util/ui.go

@@ -1,4 +1,5 @@
-//+build !windows
+//go:build !windows
+// +build !windows
 
 package util
 

cmd/ipfs/util/ulimit_freebsd.go

@@ -1,3 +1,4 @@
+//go:build freebsd
 // +build freebsd
 
 package util

cmd/ipfs/util/ulimit_test.go

@@ -1,3 +1,4 @@
+//go:build !windows && !plan9
 // +build !windows,!plan9
 
 package util

cmd/ipfs/util/ulimit_unix.go

@@ -1,3 +1,4 @@
+//go:build darwin || linux || netbsd || openbsd
 // +build darwin linux netbsd openbsd
 
 package util

cmd/ipfs/util/ulimit_windows.go

@@ -1,3 +1,4 @@
+//go:build windows
 // +build windows
 
 package util

cmd/ipfswatch/ipfswatch_test.go

@@ -1,3 +1,4 @@
+//go:build !plan9
 // +build !plan9
 
 package main

core/commands/mount_nofuse.go

@@ -1,3 +1,4 @@
+//go:build !windows && nofuse
 // +build !windows,nofuse
 
 package commands

core/commands/root.go

@@ -21,11 +21,11 @@ var ErrNotOnline = errors.New("this command must be run in online mode. Try runn
 const (
 	RepoDirOption    = "repo-dir"
 	ConfigFileOption = "config-file"
-	ConfigOption  = "config"
-	DebugOption   = "debug"
-	LocalOption   = "local" // DEPRECATED: use OfflineOption
-	OfflineOption = "offline"
-	ApiOption     = "api"
+	ConfigOption     = "config"
+	DebugOption      = "debug"
+	LocalOption      = "local" // DEPRECATED: use OfflineOption
+	OfflineOption    = "offline"
+	ApiOption        = "api"
 )
 
 var Root = &cmds.Command{

coverage/main/main.go

@@ -1,3 +1,4 @@
+//go:build testrunmain
 // +build testrunmain
 
 package main

fuse/ipns/ipns_test.go

@@ -1,3 +1,4 @@
+//go:build !nofuse && !openbsd && !netbsd && !plan9
 // +build !nofuse,!openbsd,!netbsd,!plan9
 
 package ipns

fuse/ipns/ipns_unix.go

@@ -1,3 +1,4 @@
+//go:build !nofuse && !openbsd && !netbsd && !plan9
 // +build !nofuse,!openbsd,!netbsd,!plan9
 
 // package fuse/ipns implements a fuse filesystem that interfaces

fuse/ipns/link_unix.go

@@ -1,3 +1,4 @@
+//go:build !nofuse && !openbsd && !netbsd && !plan9
 // +build !nofuse,!openbsd,!netbsd,!plan9
 
 package ipns

fuse/ipns/mount_unix.go

@@ -1,3 +1,4 @@
+//go:build (linux || darwin || freebsd || netbsd || openbsd) && !nofuse
 // +build linux darwin freebsd netbsd openbsd
 // +build !nofuse
 

fuse/mount/fuse.go

@@ -1,3 +1,4 @@
+//go:build !nofuse && !windows && !openbsd && !netbsd && !plan9
 // +build !nofuse,!windows,!openbsd,!netbsd,!plan9
 
 package mount

fuse/node/mount_darwin.go

@@ -1,3 +1,4 @@
+//go:build !nofuse
 // +build !nofuse
 
 package node

fuse/node/mount_nofuse.go

@@ -1,3 +1,4 @@
+//go:build !windows && nofuse
 // +build !windows,nofuse
 
 package node

fuse/node/mount_notsupp.go

@@ -1,3 +1,4 @@
+//go:build (!nofuse && openbsd) || (!nofuse && netbsd) || (!nofuse && plan9)
 // +build !nofuse,openbsd !nofuse,netbsd !nofuse,plan9
 
 package node

fuse/node/mount_test.go

@@ -1,3 +1,4 @@
+//go:build !openbsd && !nofuse && !netbsd && !plan9
 // +build !openbsd,!nofuse,!netbsd,!plan9
 
 package node

fuse/node/mount_unix.go

@@ -1,3 +1,4 @@
+//go:build !windows && !openbsd && !netbsd && !plan9 && !nofuse
 // +build !windows,!openbsd,!netbsd,!plan9,!nofuse
 
 package node

fuse/readonly/ipfs_test.go

@@ -1,3 +1,4 @@
+//go:build !nofuse && !openbsd && !netbsd && !plan9
 // +build !nofuse,!openbsd,!netbsd,!plan9
 
 package readonly

fuse/readonly/mount_unix.go

@@ -1,3 +1,4 @@
+//go:build (linux || darwin || freebsd) && !nofuse
 // +build linux darwin freebsd
 // +build !nofuse
 

plugin/loader/load_nocgo.go

@@ -1,4 +1,6 @@
-// +build !cgo,!noplugin
+//go:build !cgo && !noplugin && (linux || darwin || freebsd)
+// +build !cgo
+// +build !noplugin
 // +build linux darwin freebsd
 
 package loader

plugin/loader/load_noplugin.go

@@ -1,3 +1,4 @@
+//go:build noplugin
 // +build noplugin
 
 package loader

plugin/loader/load_unix.go

@@ -1,4 +1,6 @@
-// +build cgo,!noplugin
+//go:build cgo && !noplugin && (linux || darwin || freebsd)
+// +build cgo
+// +build !noplugin
 // +build linux darwin freebsd
 
 package loader

test/dependencies/dependencies.go

@@ -1,3 +1,4 @@
+//go:build tools
 // +build tools
 
 package tools