coosld/kubo
1
0
Fork 0
mirror of https://github.com/ipfs/kubo.git synced 2026-02-23 11:27:42 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

blockservice: dont write blocks twice

Browse Source 
If the datastore has a value for the key, we already have
the block. We should not write it again. This will make redundant
writes much faster.

At the moment, a datastore.Has on leveldb is a GetBackedHas.
Track https://github.com/jbenet/go-datastore/issues/6
This commit is contained in:
Juan Batiz-Benet 2014-10-30 01:54:50 -07:00
parent f0d823c2db
commit 04eba28a16
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
blockservice/blockservice.go
View File

@ -40,10 +40,21 @@ func (s *BlockService) AddBlock(b *blocks.Block) (u.Key, error) {
log.Debug("blockservice: storing [%s] in datastore", k)
// TODO(brian): define a block datastore with a Put method which accepts a
// block parameter
err := s.Datastore.Put(k.DsKey(), b.Data)
// check if we have it before adding. this is an extra read, but large writes
// are more expensive.
// TODO(jbenet) cheaper has. https://github.com/jbenet/go-datastore/issues/6
has, err := s.Datastore.Has(k.DsKey())
if err != nil {
return k, err
}
if !has {
err := s.Datastore.Put(k.DsKey(), b.Data)
if err != nil {
return k, err
}
}
if s.Remote != nil {
ctx := context.TODO()
err = s.Remote.HasBlock(ctx, *b)