coosld/kubo
1
0
Fork 0
mirror of https://github.com/ipfs/kubo.git synced 2026-03-11 19:27:51 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

fix(add): respect Provide config in fast-provide-root

Browse Source 
fast-provide-root should honor the same config settings as the regular
provide system:
- skip when Provide.Enabled is false
- skip when Provide.DHT.Interval is 0
- respect Provide.Strategy (all/pinned/roots/mfs/combinations)

This ensures fast-provide only runs when appropriate based on user
configuration and the nature of the content being added (pinned vs
unpinned, added to MFS or not).
This commit is contained in:
Marcin Rataj 2025-11-14 00:12:27 +01:00
parent 9435b5593f
commit 041ae0273b
1 changed files with 37 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
core/commands/add.go
View File

@ -602,7 +602,43 @@ https://github.com/ipfs/kubo/blob/master/docs/config.md#import
// Apply fast-provide-root if the flag is enabled
if fastProvideRoot && (lastRootCid != path.ImmutablePath{}) {
if ipfsNode.HasActiveDHTClient() {
cfg, err := ipfsNode.Repo.Config()
if err != nil {
return err
}
// Parse the provide strategy to check if we should provide based on pin/MFS status
strategyStr := cfg.Provide.Strategy.WithDefault(config.DefaultProvideStrategy)
strategy := config.ParseProvideStrategy(strategyStr)
// Determine if we should provide based on strategy
shouldProvide := false
if strategy == config.ProvideStrategyAll {
// 'all' strategy: always provide
shouldProvide = true
} else {
// For combined strategies (pinned+mfs), check each component
if strategy&config.ProvideStrategyPinned != 0 && dopin {
shouldProvide = true
}
if strategy&config.ProvideStrategyRoots != 0 && dopin {
shouldProvide = true
}
if strategy&config.ProvideStrategyMFS != 0 && toFilesSet {
shouldProvide = true
}
}
switch {
case !cfg.Provide.Enabled.WithDefault(config.DefaultProvideEnabled):
log.Debugw("fast-provide-root: skipped", "reason", "Provide.Enabled is false")
case cfg.Provide.DHT.Interval.WithDefault(config.DefaultProvideDHTInterval) == 0:
log.Debugw("fast-provide-root: skipped", "reason", "Provide.DHT.Interval is 0")
case !shouldProvide:
log.Debugw("fast-provide-root: skipped", "reason", "strategy does not match content", "strategy", strategyStr, "pinned", dopin, "to-files", toFilesSet)
case !ipfsNode.HasActiveDHTClient():
log.Debugw("fast-provide-root: skipped", "reason", "DHT not available")
default:
rootCid := lastRootCid.RootCid()
if fastProvideWait {
@ -627,8 +663,6 @@ https://github.com/ipfs/kubo/blob/master/docs/config.md#import
}
}()
}
} else {
log.Debugw("fast-provide-root: skipped", "reason", "DHT not available")
}
} else if fastProvideWait && !fastProvideRoot {
// Log that wait flag is ignored when provide-root is disabled